You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/04 08:05:51 UTC
[GitHub] [spark] nyingping commented on a change in pull request #35721: Supports customization of the entire optimizer and planner
nyingping commented on a change in pull request #35721:
URL: https://github.com/apache/spark/pull/35721#discussion_r819344793
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -242,15 +242,24 @@ abstract class BaseSessionStateBuilder(
* Note: this depends on `catalog` and `experimentalMethods` fields.
*/
protected def optimizer: Optimizer = {
- new SparkOptimizer(catalogManager, catalog, experimentalMethods) {
- override def earlyScanPushDownRules: Seq[Rule[LogicalPlan]] =
- super.earlyScanPushDownRules ++ customEarlyScanPushDownRules
+ val optimizerClassName = conf.getConfString("spark.sql.customized.optimizer", "")
+ if (optimizerClassName.nonEmpty && !optimizerClassName.equals("")) {
+ val catalogManagerTypeName = Class.forName("org.apache.spark.sql.connector.catalog.CatalogManager")
+ val sessionCatalogTypeName = Class.forName("org.apache.spark.sql.catalyst.catalog.SessionCatalog")
+ val experimentalMethodsTypeName = Class.forName("org.apache.spark.sql.ExperimentalMethods")
+ val optimizerInstance = Class.forName(optimizerClassName).getConstructor(catalogManagerTypeName, sessionCatalogTypeName, experimentalMethodsTypeName).newInstance(catalogManager, catalog, experimentalMethods)
Review comment:
file line length exceeds 100 characters on line 247,248,250 and 304
https://github.com/databricks/scala-style-guide#linelength
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -242,15 +242,24 @@ abstract class BaseSessionStateBuilder(
* Note: this depends on `catalog` and `experimentalMethods` fields.
*/
protected def optimizer: Optimizer = {
- new SparkOptimizer(catalogManager, catalog, experimentalMethods) {
- override def earlyScanPushDownRules: Seq[Rule[LogicalPlan]] =
- super.earlyScanPushDownRules ++ customEarlyScanPushDownRules
+ val optimizerClassName = conf.getConfString("spark.sql.customized.optimizer", "")
+ if (optimizerClassName.nonEmpty && !optimizerClassName.equals("")) {
+ val catalogManagerTypeName = Class.forName("org.apache.spark.sql.connector.catalog.CatalogManager")
+ val sessionCatalogTypeName = Class.forName("org.apache.spark.sql.catalyst.catalog.SessionCatalog")
+ val experimentalMethodsTypeName = Class.forName("org.apache.spark.sql.ExperimentalMethods")
+ val optimizerInstance = Class.forName(optimizerClassName).getConstructor(catalogManagerTypeName, sessionCatalogTypeName, experimentalMethodsTypeName).newInstance(catalogManager, catalog, experimentalMethods)
Review comment:
file line length exceeds 100 characters on line 247,248,250 and 304
https://github.com/databricks/scala-style-guide#linelength
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org