You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "MMirelli (via GitHub)" <gi...@apache.org> on 2024/05/17 20:14:05 UTC
[PR] Support NodePort Proxy service [pulsar-helm-chart]
MMirelli opened a new pull request, #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500
Fixes #281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500#discussion_r1605763958
##########
charts/pulsar/values.yaml:
##########
@@ -1105,6 +1105,11 @@ proxy:
## Restrict traffic through the load balancer to specified IPs on providers supporting it.
# loadBalancerSourceRanges:
# - 10.0.0.0/8
+ nodePorts:
Review Comment:
I guess it would be also necessary to document that the service type must be set to `NodePort` for this to be effective. ([comment on another issue](https://github.com/apache/pulsar-helm-chart/issues/497#issuecomment-2118784954))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "MMirelli (via GitHub)" <gi...@apache.org>.
MMirelli commented on PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500#issuecomment-2118362972
I addressed the comments, @lhotari could you PTAL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "MMirelli (via GitHub)" <gi...@apache.org>.
MMirelli commented on code in PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500#discussion_r1626063704
##########
charts/pulsar/values.yaml:
##########
@@ -1105,6 +1105,11 @@ proxy:
## Restrict traffic through the load balancer to specified IPs on providers supporting it.
# loadBalancerSourceRanges:
# - 10.0.0.0/8
+ nodePorts:
Review Comment:
absolutely forgot to add that!
Addressed by 90c06e8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "MMirelli (via GitHub)" <gi...@apache.org>.
MMirelli commented on code in PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500#discussion_r1626179388
##########
charts/pulsar/values.yaml:
##########
@@ -1105,6 +1105,11 @@ proxy:
## Restrict traffic through the load balancer to specified IPs on providers supporting it.
# loadBalancerSourceRanges:
# - 10.0.0.0/8
+ nodePorts:
Review Comment:
Just validated on my local k3d, we should be good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500#discussion_r1605762312
##########
charts/pulsar/values.yaml:
##########
@@ -1105,6 +1105,11 @@ proxy:
## Restrict traffic through the load balancer to specified IPs on providers supporting it.
# loadBalancerSourceRanges:
# - 10.0.0.0/8
+ nodePorts:
Review Comment:
Please add documentation for `nodePorts` as a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "MMirelli (via GitHub)" <gi...@apache.org>.
MMirelli commented on code in PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500#discussion_r1626066356
##########
charts/pulsar/values.yaml:
##########
@@ -1105,6 +1105,11 @@ proxy:
## Restrict traffic through the load balancer to specified IPs on providers supporting it.
# loadBalancerSourceRanges:
# - 10.0.0.0/8
+ nodePorts:
Review Comment:
Thank you very much for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support NodePort Proxy service [pulsar-helm-chart]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #500:
URL: https://github.com/apache/pulsar-helm-chart/pull/500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org