[Impala-ASF-CR] IMPALA-12380: Securing dbcp.password for JDBC external data source

["Anonymous Coward (Code Review)" <ge...@cloudera.org>]

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20809

to look at the new patch set (#4).

Change subject: IMPALA-12380: Securing dbcp.password for JDBC external data source
......................................................................

IMPALA-12380: Securing dbcp.password for JDBC
external data source

In the current implementation of external JDBC data source,
the user has to provide both the username and password in
plain text which is not a good practice.

This patch extends the functionality of existing implementation
to either provide:
a) username and password
b) username, key and keystore

If the user provides the password, then that password is used.
However, if no password is provided and the user provides only the
key/keystore, then it fetches the password from the secure jceks
keystore.

Testing:
- Added unit test TestExtDataSourcesForDbcpPassword

Change-Id: Iec83a9b6e00456f0a1bbee747bd752b2cf9bf238
---
M java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfig.java
M java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java
M java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java
A java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/secrets/SecretSource.java
M testdata/bin/copy-ext-data-sources.sh
A testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source-dbcp-password.test
M tests/custom_cluster/test_ext_data_sources.py
7 files changed, 220 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/20809/4
-- 
To view, visit http://gerrit.cloudera.org:8080/20809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec83a9b6e00456f0a1bbee747bd752b2cf9bf238
Gerrit-Change-Number: 20809
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>