You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/19 12:02:25 UTC

[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull request #15593: [WIP]Large Index Support

kshitij12345 commented on a change in pull request #15593: [WIP]Large Index Support 
URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r305325980
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -55,7 +55,8 @@ extern "C" {
 #endif
 
 /*! \brief manually define unsigned int */
-typedef unsigned int mx_uint;
+typedef int64_t mx_int64;
 
 Review comment:
   Just a nit but,
   As per the comment
   `/*! \brief manually define unsigned int */`
   Line
   `typedef int64_t mx_int64;` should be above it I guess, as it is not `unsigned`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services