[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel

[GitBox <gi...@apache.org>]

ruanwenjun commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125620889

   > > > Why does the Converter interface exist? Each engine can directly convert the sink of seatunnel to it‘s inner class when translating, and the converter just makes the class file more.
   > > 
   > > 
   > > I think Converter can make the convert logic clearer, let the engine translation implementers know what components they need to convert, and a more general code structure.
   > 
   > @ruanwenjun @CalvinKirs What do you think?
   
   If we can define a template method by converter, this will be great. Anyway, I think we need to implement this first, the code can be optimized if we find any problem. The current implementation is OK to me. 
   
   In my knowledge, we need to implement different translation for different version. For example, we may need to create a module `seatunnel-translation-flink1.11` to support flink 1.11, and create a module `seatunnel-translation-flink2.11` to support the version 2.11.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org