[GitHub] spark pull request #14034: [SPARK-16355] [SPARK-16354] [SQL] Fix Bugs When L...

[jaceklaskowski <gi...@git.apache.org>]

Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14034#discussion_r69488260
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -251,6 +251,22 @@ trait CheckAnalysis extends PredicateHelper {
                     s"but one table has '${firstError.output.length}' columns and another table has " +
                     s"'${s.children.head.output.length}' columns")
     
    +          case l: GlobalLimit =>
    +            val numRows = l.limitExpr.eval().asInstanceOf[Int]
    +            if (numRows < 0) {
    +              failAnalysis(
    +                s"number_rows in limit clause must be equal to or greater than 0. " +
    +                  s"number_rows:$numRows")
    +            }
    +
    +          case l: LocalLimit =>
    --- End diff --
    
    What do you think about merging the two cases to `case l @ (_: LocalLimit | _: GlobalLimit) =>` to remove the duplication (or at least introduce a local method).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org