[GitHub] [apisix] spacewander commented on a diff in pull request #9037: feat: bump lua-resty-ldap version for ldap-auth

["spacewander (via GitHub)" <gi...@apache.org>]

spacewander commented on code in PR #9037:
URL: https://github.com/apache/apisix/pull/9037#discussion_r1134785369


##########
apisix/plugins/ldap-auth.lua:
##########
@@ -100,6 +100,11 @@ local function extract_auth_header(authorization)
 end
 
 function _M.rewrite(conf, ctx)
+    if not ok then -- ensure rasn library loaded

Review Comment:
   For code style, we return 501 in the other similar cases:
   https://github.com/apache/apisix/blob/7e292eadd36e738f84647634b0c351bc268ea529/apisix/plugins/gzip.lua#L104-L108



##########
ci/common.sh:
##########
@@ -56,6 +56,19 @@ rerun_flaky_tests() {
     FLUSH_ETCD=1 prove --timer -I./test-nginx/lib -I./ $(echo "$tests" | xargs)
 }
 
+install_curl () {
+    wget https://curl.se/download/curl-7.88.0.tar.gz

Review Comment:
   What about exacting the version out like the other install_xxx function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org