You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hiroaki Kawai <ka...@stratosphere.co.jp> on 2013/05/22 10:06:14 UTC
Review Request: CLOUDSTACK-1194: fix that isolation method does not show in
Firefox
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11327/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
zoneWizard.js puts field name and value twice where we need only and css padding overflows in firefox rendering. The result is that isolation method pull down menu will be pushed down and hidden under the next box element.
This addresses bug CLOUDSTACK-1194.
Diffs
-----
ui/scripts/ui-custom/zoneWizard.js c31a5e0
Diff: https://reviews.apache.org/r/11327/diff/
Testing
-------
Thanks,
Hiroaki Kawai
Re: Review Request: CLOUDSTACK-1194: fix that isolation method does not show
in Firefox
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11327/#review21411
-----------------------------------------------------------
I am still not able to reproduce this issue on master. Attached the screenshot for Firefox !!
- Pranav Saxena
On May 31, 2013, 12:41 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11327/
> -----------------------------------------------------------
>
> (Updated May 31, 2013, 12:41 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Description
> -------
>
> zoneWizard.js puts field name and value twice where we need only and css padding overflows in firefox rendering. The result is that isolation method pull down menu will be pushed down and hidden under the next box element.
>
>
> This addresses bug CLOUDSTACK-1194.
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/zoneWizard.js c31a5e0
>
> Diff: https://reviews.apache.org/r/11327/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request 11327: CLOUDSTACK-1194: fix that isolation method does
not show in Firefox
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11327/#review22351
-----------------------------------------------------------
Commit 8bb43effe728952c6c8ac784cb809a59e376b228 in branch refs/heads/4.1 from Hiroaki KAWAI
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8bb43ef ]
CLOUDSTACK-1194: fix that isolation method does not show in Firefox.
zoneWizard.js puts field name and value twice where we need only
and css padding overflows in some browser rendering. The result is
that isolation method pull down menu will be pushed down and hidden
under the next box element.
- ASF Subversion and Git Services
On May 31, 2013, 12:41 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11327/
> -----------------------------------------------------------
>
> (Updated May 31, 2013, 12:41 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Bugs: CLOUDSTACK-1194
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> zoneWizard.js puts field name and value twice where we need only and css padding overflows in firefox rendering. The result is that isolation method pull down menu will be pushed down and hidden under the next box element.
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/zoneWizard.js c31a5e0
>
> Diff: https://reviews.apache.org/r/11327/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request 11327: CLOUDSTACK-1194: fix that isolation method does
not show in Firefox
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11327/#review22352
-----------------------------------------------------------
Commit 09626337ab81bcb6af6da737ec17462add6a4fb1 in branch refs/heads/master from Hiroaki KAWAI
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0962633 ]
CLOUDSTACK-1194: fix that isolation method does not show in Firefox.
zoneWizard.js puts field name and value twice where we need only
and css padding overflows in some browser rendering. The result is
that isolation method pull down menu will be pushed down and hidden
under the next box element.
- ASF Subversion and Git Services
On May 31, 2013, 12:41 a.m., Hiroaki Kawai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11327/
> -----------------------------------------------------------
>
> (Updated May 31, 2013, 12:41 a.m.)
>
>
> Review request for cloudstack and Pranav Saxena.
>
>
> Bugs: CLOUDSTACK-1194
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> zoneWizard.js puts field name and value twice where we need only and css padding overflows in firefox rendering. The result is that isolation method pull down menu will be pushed down and hidden under the next box element.
>
>
> Diffs
> -----
>
> ui/scripts/ui-custom/zoneWizard.js c31a5e0
>
> Diff: https://reviews.apache.org/r/11327/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hiroaki Kawai
>
>
Re: Review Request: CLOUDSTACK-1194: fix that isolation method does not show
in Firefox
Posted by Animesh Chaturvedi <An...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11327/
-----------------------------------------------------------
(Updated May 31, 2013, 12:41 a.m.)
Review request for cloudstack and Pranav Saxena.
Changes
-------
Added pranav as reviewer
Description
-------
zoneWizard.js puts field name and value twice where we need only and css padding overflows in firefox rendering. The result is that isolation method pull down menu will be pushed down and hidden under the next box element.
This addresses bug CLOUDSTACK-1194.
Diffs
-----
ui/scripts/ui-custom/zoneWizard.js c31a5e0
Diff: https://reviews.apache.org/r/11327/diff/
Testing
-------
Thanks,
Hiroaki Kawai