You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/13 12:23:20 UTC
[GitHub] tillrohrmann commented on a change in pull request #7295:
[FLINK-10748] Decouple RestServerEndpoint from Dispatcher
tillrohrmann commented on a change in pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher
URL: https://github.com/apache/flink/pull/7295#discussion_r241379576
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/util/HandlerRedirectUtils.java
##########
@@ -52,25 +46,6 @@
public static final Charset ENCODING = ConfigConstants.DEFAULT_CHARSET;
- public static CompletableFuture<Optional<String>> getRedirectAddress(
- String localRestAddress,
- RestfulGateway restfulGateway,
- Time timeout) {
-
- return restfulGateway.requestRestAddress(timeout).thenApply(
- (String remoteRestAddress) -> {
- if (Objects.equals(localRestAddress, remoteRestAddress)) {
- return Optional.empty();
- } else {
- return Optional.of(remoteRestAddress);
- }
- });
- }
-
- public static HttpResponse getRedirectResponse(String redirectAddress, String path) {
- return getRedirectResponse(redirectAddress, path, HttpResponseStatus.TEMPORARY_REDIRECT);
- }
-
public static HttpResponse getRedirectResponse(String redirectAddress, String path, HttpResponseStatus code) {
Review comment:
Yes exactly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services