You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/15 16:33:33 UTC
[GitHub] [iceberg] dimas-b opened a new pull request, #5770: Core: Make testEnvironmentSubstitution effective when USER is not set
dimas-b opened a new pull request, #5770:
URL: https://github.com/apache/iceberg/pull/5770
Make testEnvironmentSubstitution exercise the code under test even when the USER env. var. is not set by choosing some other available env. var.
When no env. variables are available (highly unlikely) the test is ignored.
PR #5353 allowed testEnvironmentSubstitution to pass when the USER env. var. was not set in the build environment. However, in that situation the test's logic would be equivalent to another existing test case: testEnvironmentSubstitutionWithMissingVar, and, more importantly, it would not validate that the code under test was using the right environment map (i.e. `System.getenv()`).
While the single parameter `resolveAll` method is trivial, this change allows it to be validated even when USER is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5770: Core: Make testEnvironmentSubstitution effective when USER is not set
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5770:
URL: https://github.com/apache/iceberg/pull/5770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5770: Core: Make testEnvironmentSubstitution effective when USER is not set
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5770:
URL: https://github.com/apache/iceberg/pull/5770#issuecomment-1276381292
Thanks, @dimas-b! This makes sense and improves the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org