You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/19 08:15:12 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6103: Assmebler

xiaoxiang781216 opened a new pull request, #6103:
URL: https://github.com/apache/incubator-nuttx/pull/6103

   ## Summary
   
   - arch/arm: Switch the context of save and restore from assembler to c 
   - arch/arm: Move the duplicated assembly code to common folder
   
   ## Impact
   Reduce the duplication and assembly code
   
   ## Testing
   Pass CI and ostest
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6103: arm: Remove or merge assembly code as much as possible

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6103:
URL: https://github.com/apache/incubator-nuttx/pull/6103#discussion_r852750230


##########
arch/arm/src/armv7-m/arm_exception.S:
##########
@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/arm/src/armv7-m/gnu/arm_exception.S
+ * arch/arm/src/armv7-m/arm_exception.S

Review Comment:
   > So this is compatible with IAR as well?
   
   No, I think. But IAR doesn't have the equivalent version under arch/arm/src/armv7-m/iar/, so I assume that it is provided by chip/board specific folder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6103: arm: Remove or merge assembly code as much as possible

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6103:
URL: https://github.com/apache/incubator-nuttx/pull/6103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6103: arm: Remove or merge assembly code as much as possible

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6103:
URL: https://github.com/apache/incubator-nuttx/pull/6103#discussion_r852738204


##########
arch/arm/src/armv7-m/arm_exception.S:
##########
@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/arm/src/armv7-m/gnu/arm_exception.S
+ * arch/arm/src/armv7-m/arm_exception.S

Review Comment:
   So this is compatible with IAR as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6103: arm: Remove or merge assembly code as much as possible

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6103:
URL: https://github.com/apache/incubator-nuttx/pull/6103#discussion_r852750230


##########
arch/arm/src/armv7-m/arm_exception.S:
##########
@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/arm/src/armv7-m/gnu/arm_exception.S
+ * arch/arm/src/armv7-m/arm_exception.S

Review Comment:
   > So this is compatible with IAR as well?
   
   No, I think. But IAR doesn't have the equivalent version under arch/arm/src/armv7-m/iar/, so I assume that it provide chip/board specific folder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6103: arm: Remove or merge assembly code as much as possible

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6103:
URL: https://github.com/apache/incubator-nuttx/pull/6103#discussion_r852750230


##########
arch/arm/src/armv7-m/arm_exception.S:
##########
@@ -1,5 +1,5 @@
 /****************************************************************************
- * arch/arm/src/armv7-m/gnu/arm_exception.S
+ * arch/arm/src/armv7-m/arm_exception.S

Review Comment:
   > So this is compatible with IAR as well?
   
   No, I think. But IAR doesn't have the equivalent version under arch/arm/src/armv7-m/iar/, I assume that it provide chip/board specific folder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org