You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pylucene-commits@lucene.apache.org by va...@apache.org on 2011/08/20 23:54:46 UTC

svn commit: r1159920 - in /lucene/pylucene/trunk/jcc: CHANGES jcc/python.py

Author: vajda
Date: Sat Aug 20 21:54:46 2011
New Revision: 1159920

URL: http://svn.apache.org/viewvc?rev=1159920&view=rev
Log:
  - fixed bug with generating propMethods for void getters

Modified:
    lucene/pylucene/trunk/jcc/CHANGES
    lucene/pylucene/trunk/jcc/jcc/python.py

Modified: lucene/pylucene/trunk/jcc/CHANGES
URL: http://svn.apache.org/viewvc/lucene/pylucene/trunk/jcc/CHANGES?rev=1159920&r1=1159919&r2=1159920&view=diff
==============================================================================
--- lucene/pylucene/trunk/jcc/CHANGES (original)
+++ lucene/pylucene/trunk/jcc/CHANGES Sat Aug 20 21:54:46 2011
@@ -4,6 +4,7 @@ Version 2.10 ->
  - improved recovery from toString() failure, displaying class name instead
  - non public classes listed on command line now wrapped (Lukasz Jancewicz)
  - fixed bug with generating wrappers for unimplemented interface methods
+ - fixed bug with generating propMethods for void getters
  - 
 
 Version 2.9 -> 2.10

Modified: lucene/pylucene/trunk/jcc/jcc/python.py
URL: http://svn.apache.org/viewvc/lucene/pylucene/trunk/jcc/jcc/python.py?rev=1159920&r1=1159919&r2=1159920&view=diff
==============================================================================
--- lucene/pylucene/trunk/jcc/jcc/python.py (original)
+++ lucene/pylucene/trunk/jcc/jcc/python.py Sat Aug 20 21:54:46 2011
@@ -686,14 +686,16 @@ def python(env, out_h, out, cls, superCl
                 nameLen = len(name)
                 paramsLen = len(params)
                 if nameLen > 3 and paramsLen == 0 and name.startswith('get'):
-                    propMethods.setdefault(name[3].lower() + name[4:],
-                                           []).append(method)
+                    if method.getReturnType().getName() != 'void':
+                        propMethods.setdefault(name[3].lower() + name[4:],
+                                               []).append(method)
                 elif nameLen > 3 and paramsLen == 1 and name.startswith('set'):
                     propMethods.setdefault(name[3].lower() + name[4:],
                                            []).append(method)
                 elif nameLen > 2 and paramsLen == 0 and name.startswith('is'):
-                    propMethods.setdefault(name[2].lower() + name[3:],
-                                           []).append(method)
+                    if method.getReturnType().getName() != 'void':
+                        propMethods.setdefault(name[2].lower() + name[3:],
+                                               []).append(method)
 
     properties = set([name for name in propMethods.iterkeys()
                       if name not in allMethods])