You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/27 00:19:00 UTC

[jira] [Commented] (BEAM-3083) BigQueryIO.write() with DynamicDestinations should not call getSchema() on every element

    [ https://issues.apache.org/jira/browse/BEAM-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221495#comment-16221495 ] 

ASF GitHub Bot commented on BEAM-3083:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/4047

    Pushes format function to lowest level in BigQueryIO

    This likely shuffles a lot fewer data, and also will at some point allow using a format function that formats to an Avro GenericRecord, rather than to the inefficient JSON TableRow. (though that will be usable only with BATCH_LOADS method, but that's fine)
    
    Also makes sure that getSchema() is called once per destination rather than once per element (https://issues.apache.org/jira/browse/BEAM-3083).
    
    R: @steveniemitz 
    CC: @reuvenlax 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam bq-format-fn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4047.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4047
    
----
commit 8b34098e351a22b919aecff8953a634708d3a978
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-10-26T23:17:42Z

    Pushes format function to lowest level in BigQueryIO
    
    This likely shuffles a lot fewer data, and also will at some point allow
    using a format function that formats to an Avro GenericRecord, rather
    than to the inefficient JSON TableRow.
    
    Also makes sure that getSchema() is called once per destination
    rather than once per element.

----


> BigQueryIO.write() with DynamicDestinations should not call getSchema() on every element
> ----------------------------------------------------------------------------------------
>
>                 Key: BEAM-3083
>                 URL: https://issues.apache.org/jira/browse/BEAM-3083
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Eugene Kirpichov
>            Assignee: Reuven Lax
>
> https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/CreateTables.java#L103 calls getSchema() on every element. This might be very expensive if the user expects that this will be called about once per destination.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)