You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/08 19:11:44 UTC

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #19301: Numpy roll large tensor fix fix

samskalicky commented on a change in pull request #19301:
URL: https://github.com/apache/incubator-mxnet/pull/19301#discussion_r501953015



##########
File path: src/operator/numpy/np_matrix_op-inl.h
##########
@@ -487,12 +487,12 @@ void NumpyRollCompute(const nnvm::NodeAttrs& attrs,
   CHECK_EQ(req.size(), 1U);
   if (inputs[0].Size() == 0U) return;
   const NumpyRollParam& param = nnvm::get<NumpyRollParam>(attrs.parsed);
-  const index_t ndim(inputs[0].shape_.ndim());
+  const int ndim(inputs[0].shape_.ndim());

Review comment:
       so for LTS the number of dimensions in the array is still (2^31)-1, but the size of a dimension can be bigger than 2^32?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org