You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "kamalcph (via GitHub)" <gi...@apache.org> on 2023/05/16 17:39:17 UTC

[GitHub] [kafka] kamalcph commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

kamalcph commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1195494919


##########
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##########
@@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String,
        */
       val offsetAndEpoch = leader.fetchEarliestOffset(topicPartition, currentLeaderEpoch)
       val leaderStartOffset = offsetAndEpoch.offset
-      warn(s"Reset fetch offset for partition $topicPartition from $replicaEndOffset to current " +
-        s"leader's start offset $leaderStartOffset")
       val offsetToFetch = Math.max(leaderStartOffset, replicaEndOffset)
+      warn(s"Reset fetch offset for partition $topicPartition from $replicaEndOffset to " +

Review Comment:
   Why do we have to log this at WARN level? Can we change it to the INFO level?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org