You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "leixm (via GitHub)" <gi...@apache.org> on 2024/08/07 10:45:56 UTC

[PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

leixm opened a new pull request, #2671:
URL: https://github.com/apache/celeborn/pull/2671

   ### What changes were proposed in this pull request?
   Fix wrong link in quota_management.md.
   
   
   ### Why are the changes needed?
   click `dynamic config service` in QuotaManager tab will jump to the wrong link https://celeborn.apache.org/docs/latest/quota_management/developers/configuration#dynamic-configuration
   
   ![image](https://github.com/user-attachments/assets/9c21eeb9-0302-4237-816c-ba5cd4a1cfca)
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2671:
URL: https://github.com/apache/celeborn/pull/2671#issuecomment-2275048299

   Merged to main(v0.6.0) and branch-0.5(v0.5.2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

Posted by "leixm (via GitHub)" <gi...@apache.org>.
leixm commented on code in PR #2671:
URL: https://github.com/apache/celeborn/pull/2671#discussion_r1706827433


##########
docs/quota_management.md:
##########
@@ -52,7 +52,7 @@ Users can also implement their own identity provider by inheriting the `org.apac
 ## QuotaManager
 
 `QuotaManager` supports to check whether quota is available and manage quota configurations for `Master`.
-`QuotaManager` uses the [dynamic config service](developers/configuration#dynamic-configuration) to store quota settings.
+`QuotaManager` uses the [dynamic config service](https://celeborn.apache.org/docs/latest/developers/configuration/#dynamic-configuration) to store quota settings.

Review Comment:
   ../developers/configuration#dynamic-configuration is not correct, it should be ./developers/configuration#dynamic-configuration, I'm not sure if it will display correctly on the web page.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #2671:
URL: https://github.com/apache/celeborn/pull/2671#discussion_r1706846713


##########
docs/quota_management.md:
##########
@@ -52,7 +52,7 @@ Users can also implement their own identity provider by inheriting the `org.apac
 ## QuotaManager
 
 `QuotaManager` supports to check whether quota is available and manage quota configurations for `Master`.
-`QuotaManager` uses the [dynamic config service](developers/configuration#dynamic-configuration) to store quota settings.
+`QuotaManager` uses the [dynamic config service](https://celeborn.apache.org/docs/latest/developers/configuration/#dynamic-configuration) to store quota settings.

Review Comment:
   @leixm, why is `../developers/configuration#dynamic-configuration` not correct. You could refer to the link in `client.md`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #2671:
URL: https://github.com/apache/celeborn/pull/2671#discussion_r1706811022


##########
docs/quota_management.md:
##########
@@ -52,7 +52,7 @@ Users can also implement their own identity provider by inheriting the `org.apac
 ## QuotaManager
 
 `QuotaManager` supports to check whether quota is available and manage quota configurations for `Master`.
-`QuotaManager` uses the [dynamic config service](developers/configuration#dynamic-configuration) to store quota settings.
+`QuotaManager` uses the [dynamic config service](https://celeborn.apache.org/docs/latest/developers/configuration/#dynamic-configuration) to store quota settings.

Review Comment:
   `../developers/configuration#dynamic-configuration`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

Posted by "leixm (via GitHub)" <gi...@apache.org>.
leixm commented on code in PR #2671:
URL: https://github.com/apache/celeborn/pull/2671#discussion_r1708464560


##########
docs/quota_management.md:
##########
@@ -52,7 +52,7 @@ Users can also implement their own identity provider by inheriting the `org.apac
 ## QuotaManager
 
 `QuotaManager` supports to check whether quota is available and manage quota configurations for `Master`.
-`QuotaManager` uses the [dynamic config service](developers/configuration#dynamic-configuration) to store quota settings.
+`QuotaManager` uses the [dynamic config service](https://celeborn.apache.org/docs/latest/developers/configuration/#dynamic-configuration) to store quota settings.

Review Comment:
   > @leixm, why is `../developers/configuration#dynamic-configuration` not correct. You could refer to the link in `client.md`.
   
   You are right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1551] Fix wrong link in quota_management.md [celeborn]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2671: [CELEBORN-1551] Fix wrong link in quota_management.md
URL: https://github.com/apache/celeborn/pull/2671


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org