You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/07/02 02:25:02 UTC

[GitHub] [httpcomponents-client] carterkozak commented on a change in pull request #232: HTTPCLIENT-2095: Use slf4j interpolation instead of string concatenation where possible

carterkozak commented on a change in pull request #232:
URL: https://github.com/apache/httpcomponents-client/pull/232#discussion_r448710681



##########
File path: httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachedResponseSuitabilityChecker.java
##########
@@ -195,7 +195,7 @@ public boolean canCachedResponseBeUsed(final HttpHost host, final HttpRequest re
                     }
                 } catch (final NumberFormatException ex) {
                     // err conservatively
-                    log.debug("Response from cache was malformed" + ex.getMessage());
+                    log.debug("Response from cache was malformed{}", ex.getMessage());

Review comment:
       ```suggestion
                       log.debug("Response from cache was malformed: {}", ex.getMessage());
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org