You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/18 11:21:39 UTC
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4825:
orchestration mode code optimization .
codecov-io commented on issue #4825: orchestration mode code optimization .
URL: https://github.com/apache/incubator-shardingsphere/pull/4825#issuecomment-600566986
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=h1) Report
> Merging [#4825](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6b5697580b3d5057249ecba57394f7ec07d60045&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `46.15%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4825 +/- ##
============================================
- Coverage 56.38% 56.28% -0.10%
Complexity 449 449
============================================
Files 1166 1166
Lines 20958 20939 -19
Branches 3884 3883 -1
============================================
- Hits 11817 11786 -31
- Misses 8415 8427 +12
Partials 726 726
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNlbnRlci16b29rZWVwZXItY3VyYXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jZW50ZXIvaW5zdGFuY2UvQ3VyYXRvclpvb2tlZXBlckNlbnRlclJlcG9zaXRvcnkuamF2YQ==) | `65.81% <0.00%> (ø)` | `26.00 <0.00> (ø)` | |
| [...ngsphere/orchestration/core/common/CenterType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbW1vbi9DZW50ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../orchestration/core/configcenter/ConfigCenter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9Db25maWdDZW50ZXIuamF2YQ==) | `75.90% <40.00%> (+0.90%)` | `0.00 <0.00> (ø)` | |
| [...center/listener/AuthenticationChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9BdXRoZW50aWNhdGlvbkNoYW5nZWRMaXN0ZW5lci5qYXZh) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nfigcenter/listener/PropertiesChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9Qcm9wZXJ0aWVzQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `75.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/configcenter/listener/SchemaChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbmZpZ2NlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbmZpZ2NlbnRlci9saXN0ZW5lci9TY2hlbWFDaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `72.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...enter/schema/OrchestrationShardingSchemaGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvc2NoZW1hL09yY2hlc3RyYXRpb25TaGFyZGluZ1NjaGVtYUdyb3VwLmphdmE=) | `100.00% <100.00%> (+10.00%)` | `0.00 <0.00> (ø)` | |
| [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-85.72%)` | `0.00% <0.00%> (ø%)` | |
| [.../command/query/text/query/MySQLComQueryPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvcXVlcnkvTXlTUUxDb21RdWVyeVBhY2tldC5qYXZh) | `62.50% <0.00%> (-37.50%)` | `0.00% <0.00%> (ø%)` | |
| [...ingscaling/mysql/binlog/MySQLNegotiateHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3NjYWxpbmcvbXlzcWwvYmlubG9nL015U1FMTmVnb3RpYXRlSGFuZGxlci5qYXZh) | `90.47% <0.00%> (-9.53%)` | `0.00% <0.00%> (ø%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=footer). Last update [6b56975...cc8ffde](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4825?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services