You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/28 06:41:21 UTC
[GitHub] [dubbo-go] cityiron commented on a change in pull request #811: Fix: Nacos remoting and config_center
cityiron commented on a change in pull request #811:
URL: https://github.com/apache/dubbo-go/pull/811#discussion_r513210717
##########
File path: common/constant/key.go
##########
@@ -166,7 +166,7 @@ const (
NACOS_CATEGORY_KEY = "category"
NACOS_PROTOCOL_KEY = "protocol"
NACOS_PATH_KEY = "path"
- NACOS_NAMESPACE_ID = "namespaceId"
+ NACOS_NAMESPACE_ID = "namespace"
Review comment:
when some is end with KEY, some is not, looks not friendly. `NACOS_NAMESPACE_ID ` change to `NACOS_NAMESPACE_KEY` may be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org