You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/08/15 14:48:13 UTC

Review Request 61661: Added 'latest' symlink removal.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61661/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7795
    https://issues.apache.org/jira/browse/MESOS-7795


Repository: mesos


Description
-------

After a reboot the agent checkpoints new boot ID after recovering and
agent info after registering with the master. If new agent info is
incompatible with the checkpointed one, the agent will recover as a new
one. But if the agent is restarted before registering it will fail to
start again, because new boot ID will already be checkpointed.

This patch fixes it by checkpointing the agent's decision to recover as
a new one by removing the "latest" meta symlink.


Diffs
-----

  src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 


Diff: https://reviews.apache.org/r/61661/diff/1/


Testing
-------

Ran `make check`. A new test is added in the subsequent patch.


Thanks,

Ilya Pronin

Re: Review Request 61661: Added 'latest' symlink removal.

Posted by Jiang Yan Xu <ya...@jxu.me>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61661/#review183975
-----------------------------------------------------------


Ship it!




Ship It!

- Jiang Yan Xu


On Aug. 15, 2017, 7:48 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61661/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7:48 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7795
>     https://issues.apache.org/jira/browse/MESOS-7795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After a reboot the agent checkpoints new boot ID after recovering and
> agent info after registering with the master. If new agent info is
> incompatible with the checkpointed one, the agent will recover as a new
> one. But if the agent is restarted before registering it will fail to
> start again, because new boot ID will already be checkpointed.
> 
> This patch fixes it by checkpointing the agent's decision to recover as
> a new one by removing the "latest" meta symlink.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b 
> 
> 
> Diff: https://reviews.apache.org/r/61661/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `make check`. A new test is added in the subsequent patch.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>