You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Panos Garefalakis <pa...@gmail.com> on 2021/06/21 15:07:59 UTC

[VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Hello all,

Following on previous discussions, I would like to propose a new
storage-api release including HIVE-24458
<https://issues.apache.org/jira/browse/HIVE-24458>.

Shall we release the following artifacts as Hive Storage API 2.8.0?

tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
tag: https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287

Cheers,
Panagiotis

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Dongjoon Hyun <do...@apache.org>.
Great!

Thank you, Owen and Panos!

Bests,
Dongjoon.

On 2021/07/26 16:45:38, "Owen O'Malley" <ow...@gmail.com> wrote: 
> Thanks, Dongjoon.
> 
> I've committed the fix to master and storage-branch-2.8. Given that I
> wanted to get HIVE-25190 released,
> I'll roll RCs for 2.8.1 and 2.7.3 today.
> 
> .. Owen
> 
> On Mon, Jul 26, 2021 at 8:36 AM Panos Garefalakis <pa...@gmail.com>
> wrote:
> 
> > Thanks Dongjoon for the details!
> > Looks like we are going to need a follow-up release sooner than later!
> >
> > On the positive side, HIVE-25386 <https://github.com/apache/hive/pull/2531
> > >
> > passed tests and we can now move forward.
> >
> > Cheers,
> > Panagiotis
> >
> > On Mon, Jul 26, 2021 at 9:56 AM Dongjoon Hyun <do...@apache.org> wrote:
> >
> > > Hi, All.
> > >
> > > It turns out that 2.8.0 has a regression in terms of the dependency
> > > although it passed all tests.
> > > At Apache Hive 2.2.0, HIVE-13906 removed the Guava compile dependency.
> > > However, recently, HIVE-24542 converts the test dependency to the compile
> > > dependency.
> > >
> > >
> > >
> > https://github.com/apache/hive/pull/1784/files#diff-e5e45b8481f3d87f4fa561d45b22fa20bb5084e5240d825717e6bde511b733baL122
> > >
> > > I noticed this breaking dependency change during Apache ORC integration
> > > stage.
> > >
> > > https://github.com/apache/orc/pull/773
> > >
> > > For now, I filed a JIRA issue and made a PR. Please comment your opinion
> > > on the Hive and ORC PRs.
> > > - HIVE-25386: hive-storage-api should not have guava compile dependency
> > > - https://github.com/apache/hive/pull/2531
> > >
> > > Bests,
> > > Dongjoon.
> > >
> > > On 2021/07/23 16:40:39, "Owen O'Malley" <ow...@gmail.com> wrote:
> > > > I can do the publishing. Thank you all!
> > > >
> > > > .. Owen
> > > >
> > > > On Fri, Jul 23, 2021 at 10:16 AM Panos Garefalakis <pangaref@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Thank you all for your help! With 3 binding votes this release
> > passed!
> > > > > I am going to send a vote result follow up but will need some PMC
> > help
> > > > > creating the new Storage API version (on Jira) and releasing (upload
> > > > > artifacts)!
> > > > >
> > > > > Cheers,
> > > > > Panagiotis
> > > > >
> > > > > On Fri, Jul 23, 2021 at 2:21 AM Chao Sun <su...@apache.org> wrote:
> > > > >
> > > > > > Thanks Owen! I just verified the checksum and gpg signature and
> > they
> > > both
> > > > > > look good, so +1 too.
> > > > > >
> > > > > > Panos: please fix the "Fix version" of the JIRA when you get a
> > > chance.
> > > > > > Thanks.
> > > > > >
> > > > > > Best,
> > > > > > Chao
> > > > > >
> > > > > >
> > > > > > On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <
> > > owen.omalley@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > >> Chao,
> > > > > >>    Panos key doesn't seem to have propagated to the Apache
> > servers.
> > > It
> > > > > >> referenced here:
> > > > > >>
> > > > > >> https://people.apache.org/keys/committer/ as "pgaref
> > > > > >> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
> > > > > >>
> > > > > >> The key itself can be found here:
> > > > > >>
> > > > > >>
> > > > > >>
> > > > >
> > >
> > https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
> > > > > >>
> > > > > >>
> > > > > >> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org>
> > > wrote:
> > > > > >>
> > > > > >> > I built the source from the branch and ran the tests, which all
> > > > > passed.
> > > > > >> > However I was not able to find the public GPG key. Panos: could
> > > you
> > > > > >> point
> > > > > >> > me to the location?
> > > > > >> >
> > > > > >> > Also seems we should create a new version 2.8.0 in the JIRA
> > page:
> > > > > >> >
> > > > > >> >
> > > > > >>
> > > > >
> > >
> > https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> > > > > >> > and update "Fix version" of
> > > > > >> > https://issues.apache.org/jira/browse/HIVE-24458
> > > > > >> > .
> > > > > >> >
> > > > > >> > Chao
> > > > > >> >
> > > > > >> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <
> > > szehon.apache@gmail.com>
> > > > > >> wrote:
> > > > > >> >
> > > > > >> > > +1 (binding)
> > > > > >> > >
> > > > > >> > > * Built module
> > > > > >> > > * Ran tests
> > > > > >> > > * Checked artifact checksum and signature
> > > > > >> > >
> > > > > >> > > Thanks
> > > > > >> > > Szehon
> > > > > >> > >
> > > > > >> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <
> > > > > owen.omalley@gmail.com
> > > > > >> >
> > > > > >> > > wrote:
> > > > > >> > >
> > > > > >> > > > I think we should go ahead and release storage-api 2.8.0 and
> > > catch
> > > > > >> it
> > > > > >> > on
> > > > > >> > > > the next cycle. HIVE-25190 is a long standing bug that
> > rarely
> > > > > >> affects
> > > > > >> > > > users. (We have had a user at LinkedIn hit it, which is why
> > I
> > > > > fixed
> > > > > >> > it.)
> > > > > >> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
> > > > > >> afterwards.
> > > > > >> > > >
> > > > > >> > > > .. Owen
> > > > > >> > > >
> > > > > >> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <
> > sunchao@apache.org>
> > > > > >> wrote:
> > > > > >> > > >
> > > > > >> > > > > Going to check the release and vote here too. Since
> > > HIVE-25190
> > > > > is
> > > > > >> > > already
> > > > > >> > > > > merged, instead of waiting for another release, should we
> > > start
> > > > > >> > another
> > > > > >> > > > RC1
> > > > > >> > > > > with that included?
> > > > > >> > > > >
> > > > > >> > > > > Chao
> > > > > >> > > > >
> > > > > >> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <
> > > > > >> dongjoon@apache.org>
> > > > > >> > > > wrote:
> > > > > >> > > > >
> > > > > >> > > > > > +1
> > > > > >> > > > > >
> > > > > >> > > > > > * Build and tested locally.
> > > > > >> > > > > >
> > > > > >> > > > > > Thanks,
> > > > > >> > > > > > Dongjoon.
> > > > > >> > > > > >
> > > > > >> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <
> > > > > owen.omalley@gmail.com
> > > > > >> >
> > > > > >> > > > wrote:
> > > > > >> > > > > > > +1 (binding):
> > > > > >> > > > > > > * Built and tested
> > > > > >> > > > > > > * Built hive main branch using it
> > > > > >> > > > > > > * Verified signatures and checksums
> > > > > >> > > > > > >
> > > > > >> > > > > > > It is too bad that we didn't get HIVE-25190 into it,
> > but
> > > > > that
> > > > > >> can
> > > > > >> > > > wait
> > > > > >> > > > > > for
> > > > > >> > > > > > > 2.8.1.
> > > > > >> > > > > > >
> > > > > >> > > > > > > .. Owen
> > > > > >> > > > > > >
> > > > > >> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> > > > > >> > > <planka@apple.com.invalid
> > > > > >> > > > >
> > > > > >> > > > > > > wrote:
> > > > > >> > > > > > >
> > > > > >> > > > > > > > +1 (non-binding)
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > I have done the following:
> > > > > >> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using
> > > > > OpenJDK8
> > > > > >> > > > > > > > * Built and Tested ORC with updated storage api
> > > version
> > > > > >> > > > > > > >   - Had to fix a test class that implements
> > > PredicateLeaf
> > > > > >> which
> > > > > >> > > > has a
> > > > > >> > > > > > new
> > > > > >> > > > > > > > method. This is a breaking change but I think this
> > > should
> > > > > >> be ok
> > > > > >> > > > > > > > * Verified the performance gains of HIVE-24458
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > Regards,
> > > > > >> > > > > > > > Pavan
> > > > > >> > > > > > > >
> > > > > >> > > > > > > >
> > > > > >> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > > > > >> > > > pangaref@gmail.com
> > > > > >> > > > > >
> > > > > >> > > > > > > > wrote:
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > Hello all,
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > Following on previous discussions, I would like to
> > > > > >> propose a
> > > > > >> > > new
> > > > > >> > > > > > > > > storage-api release including HIVE-24458
> > > > > >> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458
> > >.
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > Shall we release the following artifacts as Hive
> > > Storage
> > > > > >> API
> > > > > >> > > > 2.8.0?
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > tar:
> > > http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > > >> > > > > > > > > tag:
> > > > > >> > > > > > > >
> > > > > >> > > > >
> > > > > >> >
> > > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > > >> > > > > > > > > jiras:
> > > > > >> > > > > >
> > > > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > > >> > > > > > > > >
> > > > > >> > > > > > > > > Cheers,
> > > > > >> > > > > > > > > Panagiotis
> > > > > >> > > > > > > >
> > > > > >> > > > > > > >
> > > > > >> > > > > > >
> > > > > >> > > > > >
> > > > > >> > > > >
> > > > > >> > > >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> 

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Owen O'Malley <ow...@gmail.com>.
Thanks, Dongjoon.

I've committed the fix to master and storage-branch-2.8. Given that I
wanted to get HIVE-25190 released,
I'll roll RCs for 2.8.1 and 2.7.3 today.

.. Owen

On Mon, Jul 26, 2021 at 8:36 AM Panos Garefalakis <pa...@gmail.com>
wrote:

> Thanks Dongjoon for the details!
> Looks like we are going to need a follow-up release sooner than later!
>
> On the positive side, HIVE-25386 <https://github.com/apache/hive/pull/2531
> >
> passed tests and we can now move forward.
>
> Cheers,
> Panagiotis
>
> On Mon, Jul 26, 2021 at 9:56 AM Dongjoon Hyun <do...@apache.org> wrote:
>
> > Hi, All.
> >
> > It turns out that 2.8.0 has a regression in terms of the dependency
> > although it passed all tests.
> > At Apache Hive 2.2.0, HIVE-13906 removed the Guava compile dependency.
> > However, recently, HIVE-24542 converts the test dependency to the compile
> > dependency.
> >
> >
> >
> https://github.com/apache/hive/pull/1784/files#diff-e5e45b8481f3d87f4fa561d45b22fa20bb5084e5240d825717e6bde511b733baL122
> >
> > I noticed this breaking dependency change during Apache ORC integration
> > stage.
> >
> > https://github.com/apache/orc/pull/773
> >
> > For now, I filed a JIRA issue and made a PR. Please comment your opinion
> > on the Hive and ORC PRs.
> > - HIVE-25386: hive-storage-api should not have guava compile dependency
> > - https://github.com/apache/hive/pull/2531
> >
> > Bests,
> > Dongjoon.
> >
> > On 2021/07/23 16:40:39, "Owen O'Malley" <ow...@gmail.com> wrote:
> > > I can do the publishing. Thank you all!
> > >
> > > .. Owen
> > >
> > > On Fri, Jul 23, 2021 at 10:16 AM Panos Garefalakis <pangaref@gmail.com
> >
> > > wrote:
> > >
> > > > Thank you all for your help! With 3 binding votes this release
> passed!
> > > > I am going to send a vote result follow up but will need some PMC
> help
> > > > creating the new Storage API version (on Jira) and releasing (upload
> > > > artifacts)!
> > > >
> > > > Cheers,
> > > > Panagiotis
> > > >
> > > > On Fri, Jul 23, 2021 at 2:21 AM Chao Sun <su...@apache.org> wrote:
> > > >
> > > > > Thanks Owen! I just verified the checksum and gpg signature and
> they
> > both
> > > > > look good, so +1 too.
> > > > >
> > > > > Panos: please fix the "Fix version" of the JIRA when you get a
> > chance.
> > > > > Thanks.
> > > > >
> > > > > Best,
> > > > > Chao
> > > > >
> > > > >
> > > > > On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <
> > owen.omalley@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> Chao,
> > > > >>    Panos key doesn't seem to have propagated to the Apache
> servers.
> > It
> > > > >> referenced here:
> > > > >>
> > > > >> https://people.apache.org/keys/committer/ as "pgaref
> > > > >> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
> > > > >>
> > > > >> The key itself can be found here:
> > > > >>
> > > > >>
> > > > >>
> > > >
> >
> https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
> > > > >>
> > > > >>
> > > > >> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org>
> > wrote:
> > > > >>
> > > > >> > I built the source from the branch and ran the tests, which all
> > > > passed.
> > > > >> > However I was not able to find the public GPG key. Panos: could
> > you
> > > > >> point
> > > > >> > me to the location?
> > > > >> >
> > > > >> > Also seems we should create a new version 2.8.0 in the JIRA
> page:
> > > > >> >
> > > > >> >
> > > > >>
> > > >
> >
> https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> > > > >> > and update "Fix version" of
> > > > >> > https://issues.apache.org/jira/browse/HIVE-24458
> > > > >> > .
> > > > >> >
> > > > >> > Chao
> > > > >> >
> > > > >> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <
> > szehon.apache@gmail.com>
> > > > >> wrote:
> > > > >> >
> > > > >> > > +1 (binding)
> > > > >> > >
> > > > >> > > * Built module
> > > > >> > > * Ran tests
> > > > >> > > * Checked artifact checksum and signature
> > > > >> > >
> > > > >> > > Thanks
> > > > >> > > Szehon
> > > > >> > >
> > > > >> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <
> > > > owen.omalley@gmail.com
> > > > >> >
> > > > >> > > wrote:
> > > > >> > >
> > > > >> > > > I think we should go ahead and release storage-api 2.8.0 and
> > catch
> > > > >> it
> > > > >> > on
> > > > >> > > > the next cycle. HIVE-25190 is a long standing bug that
> rarely
> > > > >> affects
> > > > >> > > > users. (We have had a user at LinkedIn hit it, which is why
> I
> > > > fixed
> > > > >> > it.)
> > > > >> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
> > > > >> afterwards.
> > > > >> > > >
> > > > >> > > > .. Owen
> > > > >> > > >
> > > > >> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <
> sunchao@apache.org>
> > > > >> wrote:
> > > > >> > > >
> > > > >> > > > > Going to check the release and vote here too. Since
> > HIVE-25190
> > > > is
> > > > >> > > already
> > > > >> > > > > merged, instead of waiting for another release, should we
> > start
> > > > >> > another
> > > > >> > > > RC1
> > > > >> > > > > with that included?
> > > > >> > > > >
> > > > >> > > > > Chao
> > > > >> > > > >
> > > > >> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <
> > > > >> dongjoon@apache.org>
> > > > >> > > > wrote:
> > > > >> > > > >
> > > > >> > > > > > +1
> > > > >> > > > > >
> > > > >> > > > > > * Build and tested locally.
> > > > >> > > > > >
> > > > >> > > > > > Thanks,
> > > > >> > > > > > Dongjoon.
> > > > >> > > > > >
> > > > >> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <
> > > > owen.omalley@gmail.com
> > > > >> >
> > > > >> > > > wrote:
> > > > >> > > > > > > +1 (binding):
> > > > >> > > > > > > * Built and tested
> > > > >> > > > > > > * Built hive main branch using it
> > > > >> > > > > > > * Verified signatures and checksums
> > > > >> > > > > > >
> > > > >> > > > > > > It is too bad that we didn't get HIVE-25190 into it,
> but
> > > > that
> > > > >> can
> > > > >> > > > wait
> > > > >> > > > > > for
> > > > >> > > > > > > 2.8.1.
> > > > >> > > > > > >
> > > > >> > > > > > > .. Owen
> > > > >> > > > > > >
> > > > >> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> > > > >> > > <planka@apple.com.invalid
> > > > >> > > > >
> > > > >> > > > > > > wrote:
> > > > >> > > > > > >
> > > > >> > > > > > > > +1 (non-binding)
> > > > >> > > > > > > >
> > > > >> > > > > > > > I have done the following:
> > > > >> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using
> > > > OpenJDK8
> > > > >> > > > > > > > * Built and Tested ORC with updated storage api
> > version
> > > > >> > > > > > > >   - Had to fix a test class that implements
> > PredicateLeaf
> > > > >> which
> > > > >> > > > has a
> > > > >> > > > > > new
> > > > >> > > > > > > > method. This is a breaking change but I think this
> > should
> > > > >> be ok
> > > > >> > > > > > > > * Verified the performance gains of HIVE-24458
> > > > >> > > > > > > >
> > > > >> > > > > > > > Regards,
> > > > >> > > > > > > > Pavan
> > > > >> > > > > > > >
> > > > >> > > > > > > >
> > > > >> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > > > >> > > > pangaref@gmail.com
> > > > >> > > > > >
> > > > >> > > > > > > > wrote:
> > > > >> > > > > > > > >
> > > > >> > > > > > > > > Hello all,
> > > > >> > > > > > > > >
> > > > >> > > > > > > > > Following on previous discussions, I would like to
> > > > >> propose a
> > > > >> > > new
> > > > >> > > > > > > > > storage-api release including HIVE-24458
> > > > >> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458
> >.
> > > > >> > > > > > > > >
> > > > >> > > > > > > > > Shall we release the following artifacts as Hive
> > Storage
> > > > >> API
> > > > >> > > > 2.8.0?
> > > > >> > > > > > > > >
> > > > >> > > > > > > > > tar:
> > http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > >> > > > > > > > > tag:
> > > > >> > > > > > > >
> > > > >> > > > >
> > > > >> >
> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > >> > > > > > > > > jiras:
> > > > >> > > > > >
> > > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > >> > > > > > > > >
> > > > >> > > > > > > > > Cheers,
> > > > >> > > > > > > > > Panagiotis
> > > > >> > > > > > > >
> > > > >> > > > > > > >
> > > > >> > > > > > >
> > > > >> > > > > >
> > > > >> > > > >
> > > > >> > > >
> > > > >> > >
> > > > >> >
> > > > >>
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Panos Garefalakis <pa...@gmail.com>.
Thanks Dongjoon for the details!
Looks like we are going to need a follow-up release sooner than later!

On the positive side, HIVE-25386 <https://github.com/apache/hive/pull/2531>
passed tests and we can now move forward.

Cheers,
Panagiotis

On Mon, Jul 26, 2021 at 9:56 AM Dongjoon Hyun <do...@apache.org> wrote:

> Hi, All.
>
> It turns out that 2.8.0 has a regression in terms of the dependency
> although it passed all tests.
> At Apache Hive 2.2.0, HIVE-13906 removed the Guava compile dependency.
> However, recently, HIVE-24542 converts the test dependency to the compile
> dependency.
>
>
> https://github.com/apache/hive/pull/1784/files#diff-e5e45b8481f3d87f4fa561d45b22fa20bb5084e5240d825717e6bde511b733baL122
>
> I noticed this breaking dependency change during Apache ORC integration
> stage.
>
> https://github.com/apache/orc/pull/773
>
> For now, I filed a JIRA issue and made a PR. Please comment your opinion
> on the Hive and ORC PRs.
> - HIVE-25386: hive-storage-api should not have guava compile dependency
> - https://github.com/apache/hive/pull/2531
>
> Bests,
> Dongjoon.
>
> On 2021/07/23 16:40:39, "Owen O'Malley" <ow...@gmail.com> wrote:
> > I can do the publishing. Thank you all!
> >
> > .. Owen
> >
> > On Fri, Jul 23, 2021 at 10:16 AM Panos Garefalakis <pa...@gmail.com>
> > wrote:
> >
> > > Thank you all for your help! With 3 binding votes this release passed!
> > > I am going to send a vote result follow up but will need some PMC help
> > > creating the new Storage API version (on Jira) and releasing (upload
> > > artifacts)!
> > >
> > > Cheers,
> > > Panagiotis
> > >
> > > On Fri, Jul 23, 2021 at 2:21 AM Chao Sun <su...@apache.org> wrote:
> > >
> > > > Thanks Owen! I just verified the checksum and gpg signature and they
> both
> > > > look good, so +1 too.
> > > >
> > > > Panos: please fix the "Fix version" of the JIRA when you get a
> chance.
> > > > Thanks.
> > > >
> > > > Best,
> > > > Chao
> > > >
> > > >
> > > > On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <
> owen.omalley@gmail.com>
> > > > wrote:
> > > >
> > > >> Chao,
> > > >>    Panos key doesn't seem to have propagated to the Apache servers.
> It
> > > >> referenced here:
> > > >>
> > > >> https://people.apache.org/keys/committer/ as "pgaref
> > > >> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
> > > >>
> > > >> The key itself can be found here:
> > > >>
> > > >>
> > > >>
> > >
> https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
> > > >>
> > > >>
> > > >> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org>
> wrote:
> > > >>
> > > >> > I built the source from the branch and ran the tests, which all
> > > passed.
> > > >> > However I was not able to find the public GPG key. Panos: could
> you
> > > >> point
> > > >> > me to the location?
> > > >> >
> > > >> > Also seems we should create a new version 2.8.0 in the JIRA page:
> > > >> >
> > > >> >
> > > >>
> > >
> https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> > > >> > and update "Fix version" of
> > > >> > https://issues.apache.org/jira/browse/HIVE-24458
> > > >> > .
> > > >> >
> > > >> > Chao
> > > >> >
> > > >> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <
> szehon.apache@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> > > +1 (binding)
> > > >> > >
> > > >> > > * Built module
> > > >> > > * Ran tests
> > > >> > > * Checked artifact checksum and signature
> > > >> > >
> > > >> > > Thanks
> > > >> > > Szehon
> > > >> > >
> > > >> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <
> > > owen.omalley@gmail.com
> > > >> >
> > > >> > > wrote:
> > > >> > >
> > > >> > > > I think we should go ahead and release storage-api 2.8.0 and
> catch
> > > >> it
> > > >> > on
> > > >> > > > the next cycle. HIVE-25190 is a long standing bug that rarely
> > > >> affects
> > > >> > > > users. (We have had a user at LinkedIn hit it, which is why I
> > > fixed
> > > >> > it.)
> > > >> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
> > > >> afterwards.
> > > >> > > >
> > > >> > > > .. Owen
> > > >> > > >
> > > >> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org>
> > > >> wrote:
> > > >> > > >
> > > >> > > > > Going to check the release and vote here too. Since
> HIVE-25190
> > > is
> > > >> > > already
> > > >> > > > > merged, instead of waiting for another release, should we
> start
> > > >> > another
> > > >> > > > RC1
> > > >> > > > > with that included?
> > > >> > > > >
> > > >> > > > > Chao
> > > >> > > > >
> > > >> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <
> > > >> dongjoon@apache.org>
> > > >> > > > wrote:
> > > >> > > > >
> > > >> > > > > > +1
> > > >> > > > > >
> > > >> > > > > > * Build and tested locally.
> > > >> > > > > >
> > > >> > > > > > Thanks,
> > > >> > > > > > Dongjoon.
> > > >> > > > > >
> > > >> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <
> > > owen.omalley@gmail.com
> > > >> >
> > > >> > > > wrote:
> > > >> > > > > > > +1 (binding):
> > > >> > > > > > > * Built and tested
> > > >> > > > > > > * Built hive main branch using it
> > > >> > > > > > > * Verified signatures and checksums
> > > >> > > > > > >
> > > >> > > > > > > It is too bad that we didn't get HIVE-25190 into it, but
> > > that
> > > >> can
> > > >> > > > wait
> > > >> > > > > > for
> > > >> > > > > > > 2.8.1.
> > > >> > > > > > >
> > > >> > > > > > > .. Owen
> > > >> > > > > > >
> > > >> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> > > >> > > <planka@apple.com.invalid
> > > >> > > > >
> > > >> > > > > > > wrote:
> > > >> > > > > > >
> > > >> > > > > > > > +1 (non-binding)
> > > >> > > > > > > >
> > > >> > > > > > > > I have done the following:
> > > >> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using
> > > OpenJDK8
> > > >> > > > > > > > * Built and Tested ORC with updated storage api
> version
> > > >> > > > > > > >   - Had to fix a test class that implements
> PredicateLeaf
> > > >> which
> > > >> > > > has a
> > > >> > > > > > new
> > > >> > > > > > > > method. This is a breaking change but I think this
> should
> > > >> be ok
> > > >> > > > > > > > * Verified the performance gains of HIVE-24458
> > > >> > > > > > > >
> > > >> > > > > > > > Regards,
> > > >> > > > > > > > Pavan
> > > >> > > > > > > >
> > > >> > > > > > > >
> > > >> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > > >> > > > pangaref@gmail.com
> > > >> > > > > >
> > > >> > > > > > > > wrote:
> > > >> > > > > > > > >
> > > >> > > > > > > > > Hello all,
> > > >> > > > > > > > >
> > > >> > > > > > > > > Following on previous discussions, I would like to
> > > >> propose a
> > > >> > > new
> > > >> > > > > > > > > storage-api release including HIVE-24458
> > > >> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > >> > > > > > > > >
> > > >> > > > > > > > > Shall we release the following artifacts as Hive
> Storage
> > > >> API
> > > >> > > > 2.8.0?
> > > >> > > > > > > > >
> > > >> > > > > > > > > tar:
> http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > >> > > > > > > > > tag:
> > > >> > > > > > > >
> > > >> > > > >
> > > >> >
> https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > >> > > > > > > > > jiras:
> > > >> > > > > >
> > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > >> > > > > > > > >
> > > >> > > > > > > > > Cheers,
> > > >> > > > > > > > > Panagiotis
> > > >> > > > > > > >
> > > >> > > > > > > >
> > > >> > > > > > >
> > > >> > > > > >
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Dongjoon Hyun <do...@apache.org>.
Hi, All.

It turns out that 2.8.0 has a regression in terms of the dependency although it passed all tests.
At Apache Hive 2.2.0, HIVE-13906 removed the Guava compile dependency.
However, recently, HIVE-24542 converts the test dependency to the compile dependency.

https://github.com/apache/hive/pull/1784/files#diff-e5e45b8481f3d87f4fa561d45b22fa20bb5084e5240d825717e6bde511b733baL122

I noticed this breaking dependency change during Apache ORC integration stage.

https://github.com/apache/orc/pull/773

For now, I filed a JIRA issue and made a PR. Please comment your opinion on the Hive and ORC PRs.
- HIVE-25386: hive-storage-api should not have guava compile dependency
- https://github.com/apache/hive/pull/2531

Bests,
Dongjoon.

On 2021/07/23 16:40:39, "Owen O'Malley" <ow...@gmail.com> wrote: 
> I can do the publishing. Thank you all!
> 
> .. Owen
> 
> On Fri, Jul 23, 2021 at 10:16 AM Panos Garefalakis <pa...@gmail.com>
> wrote:
> 
> > Thank you all for your help! With 3 binding votes this release passed!
> > I am going to send a vote result follow up but will need some PMC help
> > creating the new Storage API version (on Jira) and releasing (upload
> > artifacts)!
> >
> > Cheers,
> > Panagiotis
> >
> > On Fri, Jul 23, 2021 at 2:21 AM Chao Sun <su...@apache.org> wrote:
> >
> > > Thanks Owen! I just verified the checksum and gpg signature and they both
> > > look good, so +1 too.
> > >
> > > Panos: please fix the "Fix version" of the JIRA when you get a chance.
> > > Thanks.
> > >
> > > Best,
> > > Chao
> > >
> > >
> > > On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <ow...@gmail.com>
> > > wrote:
> > >
> > >> Chao,
> > >>    Panos key doesn't seem to have propagated to the Apache servers. It
> > >> referenced here:
> > >>
> > >> https://people.apache.org/keys/committer/ as "pgaref
> > >> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
> > >>
> > >> The key itself can be found here:
> > >>
> > >>
> > >>
> > https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
> > >>
> > >>
> > >> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org> wrote:
> > >>
> > >> > I built the source from the branch and ran the tests, which all
> > passed.
> > >> > However I was not able to find the public GPG key. Panos: could you
> > >> point
> > >> > me to the location?
> > >> >
> > >> > Also seems we should create a new version 2.8.0 in the JIRA page:
> > >> >
> > >> >
> > >>
> > https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> > >> > and update "Fix version" of
> > >> > https://issues.apache.org/jira/browse/HIVE-24458
> > >> > .
> > >> >
> > >> > Chao
> > >> >
> > >> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <sz...@gmail.com>
> > >> wrote:
> > >> >
> > >> > > +1 (binding)
> > >> > >
> > >> > > * Built module
> > >> > > * Ran tests
> > >> > > * Checked artifact checksum and signature
> > >> > >
> > >> > > Thanks
> > >> > > Szehon
> > >> > >
> > >> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <
> > owen.omalley@gmail.com
> > >> >
> > >> > > wrote:
> > >> > >
> > >> > > > I think we should go ahead and release storage-api 2.8.0 and catch
> > >> it
> > >> > on
> > >> > > > the next cycle. HIVE-25190 is a long standing bug that rarely
> > >> affects
> > >> > > > users. (We have had a user at LinkedIn hit it, which is why I
> > fixed
> > >> > it.)
> > >> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
> > >> afterwards.
> > >> > > >
> > >> > > > .. Owen
> > >> > > >
> > >> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org>
> > >> wrote:
> > >> > > >
> > >> > > > > Going to check the release and vote here too. Since HIVE-25190
> > is
> > >> > > already
> > >> > > > > merged, instead of waiting for another release, should we start
> > >> > another
> > >> > > > RC1
> > >> > > > > with that included?
> > >> > > > >
> > >> > > > > Chao
> > >> > > > >
> > >> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <
> > >> dongjoon@apache.org>
> > >> > > > wrote:
> > >> > > > >
> > >> > > > > > +1
> > >> > > > > >
> > >> > > > > > * Build and tested locally.
> > >> > > > > >
> > >> > > > > > Thanks,
> > >> > > > > > Dongjoon.
> > >> > > > > >
> > >> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <
> > owen.omalley@gmail.com
> > >> >
> > >> > > > wrote:
> > >> > > > > > > +1 (binding):
> > >> > > > > > > * Built and tested
> > >> > > > > > > * Built hive main branch using it
> > >> > > > > > > * Verified signatures and checksums
> > >> > > > > > >
> > >> > > > > > > It is too bad that we didn't get HIVE-25190 into it, but
> > that
> > >> can
> > >> > > > wait
> > >> > > > > > for
> > >> > > > > > > 2.8.1.
> > >> > > > > > >
> > >> > > > > > > .. Owen
> > >> > > > > > >
> > >> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> > >> > > <planka@apple.com.invalid
> > >> > > > >
> > >> > > > > > > wrote:
> > >> > > > > > >
> > >> > > > > > > > +1 (non-binding)
> > >> > > > > > > >
> > >> > > > > > > > I have done the following:
> > >> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using
> > OpenJDK8
> > >> > > > > > > > * Built and Tested ORC with updated storage api version
> > >> > > > > > > >   - Had to fix a test class that implements PredicateLeaf
> > >> which
> > >> > > > has a
> > >> > > > > > new
> > >> > > > > > > > method. This is a breaking change but I think this should
> > >> be ok
> > >> > > > > > > > * Verified the performance gains of HIVE-24458
> > >> > > > > > > >
> > >> > > > > > > > Regards,
> > >> > > > > > > > Pavan
> > >> > > > > > > >
> > >> > > > > > > >
> > >> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > >> > > > pangaref@gmail.com
> > >> > > > > >
> > >> > > > > > > > wrote:
> > >> > > > > > > > >
> > >> > > > > > > > > Hello all,
> > >> > > > > > > > >
> > >> > > > > > > > > Following on previous discussions, I would like to
> > >> propose a
> > >> > > new
> > >> > > > > > > > > storage-api release including HIVE-24458
> > >> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > >> > > > > > > > >
> > >> > > > > > > > > Shall we release the following artifacts as Hive Storage
> > >> API
> > >> > > > 2.8.0?
> > >> > > > > > > > >
> > >> > > > > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > >> > > > > > > > > tag:
> > >> > > > > > > >
> > >> > > > >
> > >> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > >> > > > > > > > > jiras:
> > >> > > > > >
> > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > >> > > > > > > > >
> > >> > > > > > > > > Cheers,
> > >> > > > > > > > > Panagiotis
> > >> > > > > > > >
> > >> > > > > > > >
> > >> > > > > > >
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> >
> 

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Owen O'Malley <ow...@gmail.com>.
I can do the publishing. Thank you all!

.. Owen

On Fri, Jul 23, 2021 at 10:16 AM Panos Garefalakis <pa...@gmail.com>
wrote:

> Thank you all for your help! With 3 binding votes this release passed!
> I am going to send a vote result follow up but will need some PMC help
> creating the new Storage API version (on Jira) and releasing (upload
> artifacts)!
>
> Cheers,
> Panagiotis
>
> On Fri, Jul 23, 2021 at 2:21 AM Chao Sun <su...@apache.org> wrote:
>
> > Thanks Owen! I just verified the checksum and gpg signature and they both
> > look good, so +1 too.
> >
> > Panos: please fix the "Fix version" of the JIRA when you get a chance.
> > Thanks.
> >
> > Best,
> > Chao
> >
> >
> > On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <ow...@gmail.com>
> > wrote:
> >
> >> Chao,
> >>    Panos key doesn't seem to have propagated to the Apache servers. It
> >> referenced here:
> >>
> >> https://people.apache.org/keys/committer/ as "pgaref
> >> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
> >>
> >> The key itself can be found here:
> >>
> >>
> >>
> https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
> >>
> >>
> >> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org> wrote:
> >>
> >> > I built the source from the branch and ran the tests, which all
> passed.
> >> > However I was not able to find the public GPG key. Panos: could you
> >> point
> >> > me to the location?
> >> >
> >> > Also seems we should create a new version 2.8.0 in the JIRA page:
> >> >
> >> >
> >>
> https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> >> > and update "Fix version" of
> >> > https://issues.apache.org/jira/browse/HIVE-24458
> >> > .
> >> >
> >> > Chao
> >> >
> >> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <sz...@gmail.com>
> >> wrote:
> >> >
> >> > > +1 (binding)
> >> > >
> >> > > * Built module
> >> > > * Ran tests
> >> > > * Checked artifact checksum and signature
> >> > >
> >> > > Thanks
> >> > > Szehon
> >> > >
> >> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <
> owen.omalley@gmail.com
> >> >
> >> > > wrote:
> >> > >
> >> > > > I think we should go ahead and release storage-api 2.8.0 and catch
> >> it
> >> > on
> >> > > > the next cycle. HIVE-25190 is a long standing bug that rarely
> >> affects
> >> > > > users. (We have had a user at LinkedIn hit it, which is why I
> fixed
> >> > it.)
> >> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
> >> afterwards.
> >> > > >
> >> > > > .. Owen
> >> > > >
> >> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org>
> >> wrote:
> >> > > >
> >> > > > > Going to check the release and vote here too. Since HIVE-25190
> is
> >> > > already
> >> > > > > merged, instead of waiting for another release, should we start
> >> > another
> >> > > > RC1
> >> > > > > with that included?
> >> > > > >
> >> > > > > Chao
> >> > > > >
> >> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <
> >> dongjoon@apache.org>
> >> > > > wrote:
> >> > > > >
> >> > > > > > +1
> >> > > > > >
> >> > > > > > * Build and tested locally.
> >> > > > > >
> >> > > > > > Thanks,
> >> > > > > > Dongjoon.
> >> > > > > >
> >> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <
> owen.omalley@gmail.com
> >> >
> >> > > > wrote:
> >> > > > > > > +1 (binding):
> >> > > > > > > * Built and tested
> >> > > > > > > * Built hive main branch using it
> >> > > > > > > * Verified signatures and checksums
> >> > > > > > >
> >> > > > > > > It is too bad that we didn't get HIVE-25190 into it, but
> that
> >> can
> >> > > > wait
> >> > > > > > for
> >> > > > > > > 2.8.1.
> >> > > > > > >
> >> > > > > > > .. Owen
> >> > > > > > >
> >> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> >> > > <planka@apple.com.invalid
> >> > > > >
> >> > > > > > > wrote:
> >> > > > > > >
> >> > > > > > > > +1 (non-binding)
> >> > > > > > > >
> >> > > > > > > > I have done the following:
> >> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using
> OpenJDK8
> >> > > > > > > > * Built and Tested ORC with updated storage api version
> >> > > > > > > >   - Had to fix a test class that implements PredicateLeaf
> >> which
> >> > > > has a
> >> > > > > > new
> >> > > > > > > > method. This is a breaking change but I think this should
> >> be ok
> >> > > > > > > > * Verified the performance gains of HIVE-24458
> >> > > > > > > >
> >> > > > > > > > Regards,
> >> > > > > > > > Pavan
> >> > > > > > > >
> >> > > > > > > >
> >> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> >> > > > pangaref@gmail.com
> >> > > > > >
> >> > > > > > > > wrote:
> >> > > > > > > > >
> >> > > > > > > > > Hello all,
> >> > > > > > > > >
> >> > > > > > > > > Following on previous discussions, I would like to
> >> propose a
> >> > > new
> >> > > > > > > > > storage-api release including HIVE-24458
> >> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> >> > > > > > > > >
> >> > > > > > > > > Shall we release the following artifacts as Hive Storage
> >> API
> >> > > > 2.8.0?
> >> > > > > > > > >
> >> > > > > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> >> > > > > > > > > tag:
> >> > > > > > > >
> >> > > > >
> >> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> >> > > > > > > > > jiras:
> >> > > > > >
> https://issues.apache.org/jira/projects/HIVE/versions/12350287
> >> > > > > > > > >
> >> > > > > > > > > Cheers,
> >> > > > > > > > > Panagiotis
> >> > > > > > > >
> >> > > > > > > >
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Panos Garefalakis <pa...@gmail.com>.
Thank you all for your help! With 3 binding votes this release passed!
I am going to send a vote result follow up but will need some PMC help
creating the new Storage API version (on Jira) and releasing (upload
artifacts)!

Cheers,
Panagiotis

On Fri, Jul 23, 2021 at 2:21 AM Chao Sun <su...@apache.org> wrote:

> Thanks Owen! I just verified the checksum and gpg signature and they both
> look good, so +1 too.
>
> Panos: please fix the "Fix version" of the JIRA when you get a chance.
> Thanks.
>
> Best,
> Chao
>
>
> On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <ow...@gmail.com>
> wrote:
>
>> Chao,
>>    Panos key doesn't seem to have propagated to the Apache servers. It
>> referenced here:
>>
>> https://people.apache.org/keys/committer/ as "pgaref
>> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
>>
>> The key itself can be found here:
>>
>>
>> https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
>>
>>
>> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org> wrote:
>>
>> > I built the source from the branch and ran the tests, which all passed.
>> > However I was not able to find the public GPG key. Panos: could you
>> point
>> > me to the location?
>> >
>> > Also seems we should create a new version 2.8.0 in the JIRA page:
>> >
>> >
>> https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
>> > and update "Fix version" of
>> > https://issues.apache.org/jira/browse/HIVE-24458
>> > .
>> >
>> > Chao
>> >
>> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <sz...@gmail.com>
>> wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > * Built module
>> > > * Ran tests
>> > > * Checked artifact checksum and signature
>> > >
>> > > Thanks
>> > > Szehon
>> > >
>> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <owen.omalley@gmail.com
>> >
>> > > wrote:
>> > >
>> > > > I think we should go ahead and release storage-api 2.8.0 and catch
>> it
>> > on
>> > > > the next cycle. HIVE-25190 is a long standing bug that rarely
>> affects
>> > > > users. (We have had a user at LinkedIn hit it, which is why I fixed
>> > it.)
>> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
>> afterwards.
>> > > >
>> > > > .. Owen
>> > > >
>> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org>
>> wrote:
>> > > >
>> > > > > Going to check the release and vote here too. Since HIVE-25190 is
>> > > already
>> > > > > merged, instead of waiting for another release, should we start
>> > another
>> > > > RC1
>> > > > > with that included?
>> > > > >
>> > > > > Chao
>> > > > >
>> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <
>> dongjoon@apache.org>
>> > > > wrote:
>> > > > >
>> > > > > > +1
>> > > > > >
>> > > > > > * Build and tested locally.
>> > > > > >
>> > > > > > Thanks,
>> > > > > > Dongjoon.
>> > > > > >
>> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <owen.omalley@gmail.com
>> >
>> > > > wrote:
>> > > > > > > +1 (binding):
>> > > > > > > * Built and tested
>> > > > > > > * Built hive main branch using it
>> > > > > > > * Verified signatures and checksums
>> > > > > > >
>> > > > > > > It is too bad that we didn't get HIVE-25190 into it, but that
>> can
>> > > > wait
>> > > > > > for
>> > > > > > > 2.8.1.
>> > > > > > >
>> > > > > > > .. Owen
>> > > > > > >
>> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
>> > > <planka@apple.com.invalid
>> > > > >
>> > > > > > > wrote:
>> > > > > > >
>> > > > > > > > +1 (non-binding)
>> > > > > > > >
>> > > > > > > > I have done the following:
>> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
>> > > > > > > > * Built and Tested ORC with updated storage api version
>> > > > > > > >   - Had to fix a test class that implements PredicateLeaf
>> which
>> > > > has a
>> > > > > > new
>> > > > > > > > method. This is a breaking change but I think this should
>> be ok
>> > > > > > > > * Verified the performance gains of HIVE-24458
>> > > > > > > >
>> > > > > > > > Regards,
>> > > > > > > > Pavan
>> > > > > > > >
>> > > > > > > >
>> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
>> > > > pangaref@gmail.com
>> > > > > >
>> > > > > > > > wrote:
>> > > > > > > > >
>> > > > > > > > > Hello all,
>> > > > > > > > >
>> > > > > > > > > Following on previous discussions, I would like to
>> propose a
>> > > new
>> > > > > > > > > storage-api release including HIVE-24458
>> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
>> > > > > > > > >
>> > > > > > > > > Shall we release the following artifacts as Hive Storage
>> API
>> > > > 2.8.0?
>> > > > > > > > >
>> > > > > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
>> > > > > > > > > tag:
>> > > > > > > >
>> > > > >
>> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
>> > > > > > > > > jiras:
>> > > > > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
>> > > > > > > > >
>> > > > > > > > > Cheers,
>> > > > > > > > > Panagiotis
>> > > > > > > >
>> > > > > > > >
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Chao Sun <su...@apache.org>.
Thanks Owen! I just verified the checksum and gpg signature and they both
look good, so +1 too.

Panos: please fix the "Fix version" of the JIRA when you get a chance.
Thanks.

Best,
Chao


On Thu, Jul 22, 2021 at 2:29 PM Owen O'Malley <ow...@gmail.com>
wrote:

> Chao,
>    Panos key doesn't seem to have propagated to the Apache servers. It
> referenced here:
>
> https://people.apache.org/keys/committer/ as "pgaref
> 7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"
>
> The key itself can be found here:
>
>
> https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index
>
>
> On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org> wrote:
>
> > I built the source from the branch and ran the tests, which all passed.
> > However I was not able to find the public GPG key. Panos: could you point
> > me to the location?
> >
> > Also seems we should create a new version 2.8.0 in the JIRA page:
> >
> >
> https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> > and update "Fix version" of
> > https://issues.apache.org/jira/browse/HIVE-24458
> > .
> >
> > Chao
> >
> > On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <sz...@gmail.com>
> wrote:
> >
> > > +1 (binding)
> > >
> > > * Built module
> > > * Ran tests
> > > * Checked artifact checksum and signature
> > >
> > > Thanks
> > > Szehon
> > >
> > > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <ow...@gmail.com>
> > > wrote:
> > >
> > > > I think we should go ahead and release storage-api 2.8.0 and catch it
> > on
> > > > the next cycle. HIVE-25190 is a long standing bug that rarely affects
> > > > users. (We have had a user at LinkedIn hit it, which is why I fixed
> > it.)
> > > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases
> afterwards.
> > > >
> > > > .. Owen
> > > >
> > > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org> wrote:
> > > >
> > > > > Going to check the release and vote here too. Since HIVE-25190 is
> > > already
> > > > > merged, instead of waiting for another release, should we start
> > another
> > > > RC1
> > > > > with that included?
> > > > >
> > > > > Chao
> > > > >
> > > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <dongjoon@apache.org
> >
> > > > wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > * Build and tested locally.
> > > > > >
> > > > > > Thanks,
> > > > > > Dongjoon.
> > > > > >
> > > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com>
> > > > wrote:
> > > > > > > +1 (binding):
> > > > > > > * Built and tested
> > > > > > > * Built hive main branch using it
> > > > > > > * Verified signatures and checksums
> > > > > > >
> > > > > > > It is too bad that we didn't get HIVE-25190 into it, but that
> can
> > > > wait
> > > > > > for
> > > > > > > 2.8.1.
> > > > > > >
> > > > > > > .. Owen
> > > > > > >
> > > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> > > <planka@apple.com.invalid
> > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > > > +1 (non-binding)
> > > > > > > >
> > > > > > > > I have done the following:
> > > > > > > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > > > > > > > * Built and Tested ORC with updated storage api version
> > > > > > > >   - Had to fix a test class that implements PredicateLeaf
> which
> > > > has a
> > > > > > new
> > > > > > > > method. This is a breaking change but I think this should be
> ok
> > > > > > > > * Verified the performance gains of HIVE-24458
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > > Pavan
> > > > > > > >
> > > > > > > >
> > > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > > > pangaref@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Hello all,
> > > > > > > > >
> > > > > > > > > Following on previous discussions, I would like to propose
> a
> > > new
> > > > > > > > > storage-api release including HIVE-24458
> > > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > > > > > > >
> > > > > > > > > Shall we release the following artifacts as Hive Storage
> API
> > > > 2.8.0?
> > > > > > > > >
> > > > > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > > > > > > tag:
> > > > > > > >
> > > > >
> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > > > > > > jiras:
> > > > > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > > > > > >
> > > > > > > > > Cheers,
> > > > > > > > > Panagiotis
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Owen O'Malley <ow...@gmail.com>.
Chao,
   Panos key doesn't seem to have propagated to the Apache servers. It
referenced here:

https://people.apache.org/keys/committer/ as "pgaref
7DFAB216AB7D96B3B2072184DC11DE4D00F8FA1D"

The key itself can be found here:

https://keyserver.ubuntu.com/pks/lookup?search=pgaref&fingerprint=on&op=index


On Wed, Jul 21, 2021 at 8:47 PM Chao Sun <su...@apache.org> wrote:

> I built the source from the branch and ran the tests, which all passed.
> However I was not able to find the public GPG key. Panos: could you point
> me to the location?
>
> Also seems we should create a new version 2.8.0 in the JIRA page:
>
> https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
> and update "Fix version" of
> https://issues.apache.org/jira/browse/HIVE-24458
> .
>
> Chao
>
> On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <sz...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > * Built module
> > * Ran tests
> > * Checked artifact checksum and signature
> >
> > Thanks
> > Szehon
> >
> > On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <ow...@gmail.com>
> > wrote:
> >
> > > I think we should go ahead and release storage-api 2.8.0 and catch it
> on
> > > the next cycle. HIVE-25190 is a long standing bug that rarely affects
> > > users. (We have had a user at LinkedIn hit it, which is why I fixed
> it.)
> > > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases afterwards.
> > >
> > > .. Owen
> > >
> > > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org> wrote:
> > >
> > > > Going to check the release and vote here too. Since HIVE-25190 is
> > already
> > > > merged, instead of waiting for another release, should we start
> another
> > > RC1
> > > > with that included?
> > > >
> > > > Chao
> > > >
> > > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <do...@apache.org>
> > > wrote:
> > > >
> > > > > +1
> > > > >
> > > > > * Build and tested locally.
> > > > >
> > > > > Thanks,
> > > > > Dongjoon.
> > > > >
> > > > > On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com>
> > > wrote:
> > > > > > +1 (binding):
> > > > > > * Built and tested
> > > > > > * Built hive main branch using it
> > > > > > * Verified signatures and checksums
> > > > > >
> > > > > > It is too bad that we didn't get HIVE-25190 into it, but that can
> > > wait
> > > > > for
> > > > > > 2.8.1.
> > > > > >
> > > > > > .. Owen
> > > > > >
> > > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> > <planka@apple.com.invalid
> > > >
> > > > > > wrote:
> > > > > >
> > > > > > > +1 (non-binding)
> > > > > > >
> > > > > > > I have done the following:
> > > > > > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > > > > > > * Built and Tested ORC with updated storage api version
> > > > > > >   - Had to fix a test class that implements PredicateLeaf which
> > > has a
> > > > > new
> > > > > > > method. This is a breaking change but I think this should be ok
> > > > > > > * Verified the performance gains of HIVE-24458
> > > > > > >
> > > > > > > Regards,
> > > > > > > Pavan
> > > > > > >
> > > > > > >
> > > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > > pangaref@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > Hello all,
> > > > > > > >
> > > > > > > > Following on previous discussions, I would like to propose a
> > new
> > > > > > > > storage-api release including HIVE-24458
> > > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > > > > > >
> > > > > > > > Shall we release the following artifacts as Hive Storage API
> > > 2.8.0?
> > > > > > > >
> > > > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > > > > > tag:
> > > > > > >
> > > >
> https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > > > > > jiras:
> > > > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > > > > >
> > > > > > > > Cheers,
> > > > > > > > Panagiotis
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Chao Sun <su...@apache.org>.
I built the source from the branch and ran the tests, which all passed.
However I was not able to find the public GPG key. Panos: could you point
me to the location?

Also seems we should create a new version 2.8.0 in the JIRA page:
https://issues.apache.org/jira/projects/HIVE?selectedItem=com.atlassian.jira.jira-projects-plugin:release-page
and update "Fix version" of https://issues.apache.org/jira/browse/HIVE-24458
.

Chao

On Wed, Jul 21, 2021 at 9:10 AM Szehon Ho <sz...@gmail.com> wrote:

> +1 (binding)
>
> * Built module
> * Ran tests
> * Checked artifact checksum and signature
>
> Thanks
> Szehon
>
> On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <ow...@gmail.com>
> wrote:
>
> > I think we should go ahead and release storage-api 2.8.0 and catch it on
> > the next cycle. HIVE-25190 is a long standing bug that rarely affects
> > users. (We have had a user at LinkedIn hit it, which is why I fixed it.)
> > I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases afterwards.
> >
> > .. Owen
> >
> > On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org> wrote:
> >
> > > Going to check the release and vote here too. Since HIVE-25190 is
> already
> > > merged, instead of waiting for another release, should we start another
> > RC1
> > > with that included?
> > >
> > > Chao
> > >
> > > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <do...@apache.org>
> > wrote:
> > >
> > > > +1
> > > >
> > > > * Build and tested locally.
> > > >
> > > > Thanks,
> > > > Dongjoon.
> > > >
> > > > On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com>
> > wrote:
> > > > > +1 (binding):
> > > > > * Built and tested
> > > > > * Built hive main branch using it
> > > > > * Verified signatures and checksums
> > > > >
> > > > > It is too bad that we didn't get HIVE-25190 into it, but that can
> > wait
> > > > for
> > > > > 2.8.1.
> > > > >
> > > > > .. Owen
> > > > >
> > > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka
> <planka@apple.com.invalid
> > >
> > > > > wrote:
> > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > I have done the following:
> > > > > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > > > > > * Built and Tested ORC with updated storage api version
> > > > > >   - Had to fix a test class that implements PredicateLeaf which
> > has a
> > > > new
> > > > > > method. This is a breaking change but I think this should be ok
> > > > > > * Verified the performance gains of HIVE-24458
> > > > > >
> > > > > > Regards,
> > > > > > Pavan
> > > > > >
> > > > > >
> > > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> > pangaref@gmail.com
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > Hello all,
> > > > > > >
> > > > > > > Following on previous discussions, I would like to propose a
> new
> > > > > > > storage-api release including HIVE-24458
> > > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > > > > >
> > > > > > > Shall we release the following artifacts as Hive Storage API
> > 2.8.0?
> > > > > > >
> > > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > > > > tag:
> > > > > >
> > > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > > > > jiras:
> > > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Panagiotis
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Szehon Ho <sz...@gmail.com>.
+1 (binding)

* Built module
* Ran tests
* Checked artifact checksum and signature

Thanks
Szehon

On Tue, Jul 20, 2021 at 2:11 PM Owen O'Malley <ow...@gmail.com>
wrote:

> I think we should go ahead and release storage-api 2.8.0 and catch it on
> the next cycle. HIVE-25190 is a long standing bug that rarely affects
> users. (We have had a user at LinkedIn hit it, which is why I fixed it.)
> I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases afterwards.
>
> .. Owen
>
> On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org> wrote:
>
> > Going to check the release and vote here too. Since HIVE-25190 is already
> > merged, instead of waiting for another release, should we start another
> RC1
> > with that included?
> >
> > Chao
> >
> > On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <do...@apache.org>
> wrote:
> >
> > > +1
> > >
> > > * Build and tested locally.
> > >
> > > Thanks,
> > > Dongjoon.
> > >
> > > On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com>
> wrote:
> > > > +1 (binding):
> > > > * Built and tested
> > > > * Built hive main branch using it
> > > > * Verified signatures and checksums
> > > >
> > > > It is too bad that we didn't get HIVE-25190 into it, but that can
> wait
> > > for
> > > > 2.8.1.
> > > >
> > > > .. Owen
> > > >
> > > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka <planka@apple.com.invalid
> >
> > > > wrote:
> > > >
> > > > > +1 (non-binding)
> > > > >
> > > > > I have done the following:
> > > > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > > > > * Built and Tested ORC with updated storage api version
> > > > >   - Had to fix a test class that implements PredicateLeaf which
> has a
> > > new
> > > > > method. This is a breaking change but I think this should be ok
> > > > > * Verified the performance gains of HIVE-24458
> > > > >
> > > > > Regards,
> > > > > Pavan
> > > > >
> > > > >
> > > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <
> pangaref@gmail.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > Hello all,
> > > > > >
> > > > > > Following on previous discussions, I would like to propose a new
> > > > > > storage-api release including HIVE-24458
> > > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > > > >
> > > > > > Shall we release the following artifacts as Hive Storage API
> 2.8.0?
> > > > > >
> > > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > > > tag:
> > > > >
> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > > > jiras:
> > > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > > >
> > > > > > Cheers,
> > > > > > Panagiotis
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Owen O'Malley <ow...@gmail.com>.
I think we should go ahead and release storage-api 2.8.0 and catch it on
the next cycle. HIVE-25190 is a long standing bug that rarely affects
users. (We have had a user at LinkedIn hit it, which is why I fixed it.)
I'll sign up to make the 2.8.1 (and 2.7.3) bug fix releases afterwards.

.. Owen

On Tue, Jul 20, 2021 at 8:53 PM Chao Sun <su...@apache.org> wrote:

> Going to check the release and vote here too. Since HIVE-25190 is already
> merged, instead of waiting for another release, should we start another RC1
> with that included?
>
> Chao
>
> On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <do...@apache.org> wrote:
>
> > +1
> >
> > * Build and tested locally.
> >
> > Thanks,
> > Dongjoon.
> >
> > On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com> wrote:
> > > +1 (binding):
> > > * Built and tested
> > > * Built hive main branch using it
> > > * Verified signatures and checksums
> > >
> > > It is too bad that we didn't get HIVE-25190 into it, but that can wait
> > for
> > > 2.8.1.
> > >
> > > .. Owen
> > >
> > > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka <pl...@apple.com.invalid>
> > > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > I have done the following:
> > > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > > > * Built and Tested ORC with updated storage api version
> > > >   - Had to fix a test class that implements PredicateLeaf which has a
> > new
> > > > method. This is a breaking change but I think this should be ok
> > > > * Verified the performance gains of HIVE-24458
> > > >
> > > > Regards,
> > > > Pavan
> > > >
> > > >
> > > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <pangaref@gmail.com
> >
> > > > wrote:
> > > > >
> > > > > Hello all,
> > > > >
> > > > > Following on previous discussions, I would like to propose a new
> > > > > storage-api release including HIVE-24458
> > > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > > >
> > > > > Shall we release the following artifacts as Hive Storage API 2.8.0?
> > > > >
> > > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > > tag:
> > > >
> https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > > jiras:
> > https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > > >
> > > > > Cheers,
> > > > > Panagiotis
> > > >
> > > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Chao Sun <su...@apache.org>.
Going to check the release and vote here too. Since HIVE-25190 is already
merged, instead of waiting for another release, should we start another RC1
with that included?

Chao

On Tue, Jul 20, 2021 at 1:30 PM Dongjoon Hyun <do...@apache.org> wrote:

> +1
>
> * Build and tested locally.
>
> Thanks,
> Dongjoon.
>
> On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com> wrote:
> > +1 (binding):
> > * Built and tested
> > * Built hive main branch using it
> > * Verified signatures and checksums
> >
> > It is too bad that we didn't get HIVE-25190 into it, but that can wait
> for
> > 2.8.1.
> >
> > .. Owen
> >
> > On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka <pl...@apple.com.invalid>
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > I have done the following:
> > > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > > * Built and Tested ORC with updated storage api version
> > >   - Had to fix a test class that implements PredicateLeaf which has a
> new
> > > method. This is a breaking change but I think this should be ok
> > > * Verified the performance gains of HIVE-24458
> > >
> > > Regards,
> > > Pavan
> > >
> > >
> > > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <pa...@gmail.com>
> > > wrote:
> > > >
> > > > Hello all,
> > > >
> > > > Following on previous discussions, I would like to propose a new
> > > > storage-api release including HIVE-24458
> > > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > > >
> > > > Shall we release the following artifacts as Hive Storage API 2.8.0?
> > > >
> > > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > > tag:
> > > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > > jiras:
> https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > > >
> > > > Cheers,
> > > > Panagiotis
> > >
> > >
> >
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Dongjoon Hyun <do...@apache.org>.
+1

* Build and tested locally.

Thanks,
Dongjoon.

On 2021/07/19 23:15:46, "Owen O'Malley" <ow...@gmail.com> wrote: 
> +1 (binding):
> * Built and tested
> * Built hive main branch using it
> * Verified signatures and checksums
> 
> It is too bad that we didn't get HIVE-25190 into it, but that can wait for
> 2.8.1.
> 
> .. Owen
> 
> On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka <pl...@apple.com.invalid>
> wrote:
> 
> > +1 (non-binding)
> >
> > I have done the following:
> > * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> > * Built and Tested ORC with updated storage api version
> >   - Had to fix a test class that implements PredicateLeaf which has a new
> > method. This is a breaking change but I think this should be ok
> > * Verified the performance gains of HIVE-24458
> >
> > Regards,
> > Pavan
> >
> >
> > > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <pa...@gmail.com>
> > wrote:
> > >
> > > Hello all,
> > >
> > > Following on previous discussions, I would like to propose a new
> > > storage-api release including HIVE-24458
> > > <https://issues.apache.org/jira/browse/HIVE-24458>.
> > >
> > > Shall we release the following artifacts as Hive Storage API 2.8.0?
> > >
> > > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > > tag:
> > https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > > jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
> > >
> > > Cheers,
> > > Panagiotis
> >
> >
> 

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Owen O'Malley <ow...@gmail.com>.
+1 (binding):
* Built and tested
* Built hive main branch using it
* Verified signatures and checksums

It is too bad that we didn't get HIVE-25190 into it, but that can wait for
2.8.1.

.. Owen

On Mon, Jun 28, 2021 at 9:44 PM Pavan Lanka <pl...@apple.com.invalid>
wrote:

> +1 (non-binding)
>
> I have done the following:
> * Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
> * Built and Tested ORC with updated storage api version
>   - Had to fix a test class that implements PredicateLeaf which has a new
> method. This is a breaking change but I think this should be ok
> * Verified the performance gains of HIVE-24458
>
> Regards,
> Pavan
>
>
> > On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <pa...@gmail.com>
> wrote:
> >
> > Hello all,
> >
> > Following on previous discussions, I would like to propose a new
> > storage-api release including HIVE-24458
> > <https://issues.apache.org/jira/browse/HIVE-24458>.
> >
> > Shall we release the following artifacts as Hive Storage API 2.8.0?
> >
> > tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> > tag:
> https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> > jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
> >
> > Cheers,
> > Panagiotis
>
>

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

Posted by Pavan Lanka <pl...@apple.com.INVALID>.
+1 (non-binding)

I have done the following:
* Built and Tested storage-release-2.8.0-rc0 using OpenJDK8
* Built and Tested ORC with updated storage api version 
  - Had to fix a test class that implements PredicateLeaf which has a new method. This is a breaking change but I think this should be ok
* Verified the performance gains of HIVE-24458

Regards,
Pavan


> On Jun 21, 2021, at 8:07 AM, Panos Garefalakis <pa...@gmail.com> wrote:
> 
> Hello all,
> 
> Following on previous discussions, I would like to propose a new
> storage-api release including HIVE-24458
> <https://issues.apache.org/jira/browse/HIVE-24458>.
> 
> Shall we release the following artifacts as Hive Storage API 2.8.0?
> 
> tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/
> tag: https://github.com/apache/hive/releases/tag/storage-release-2.8.0-rc0
> jiras: https://issues.apache.org/jira/projects/HIVE/versions/12350287
> 
> Cheers,
> Panagiotis