Re: [PR] Enhance parsing the Doris create materialized view [shardingsphere]

["Copilot (via GitHub)" <gi...@apache.org>]

Copilot commented on code in PR #34943:
URL: https://github.com/apache/shardingsphere/pull/34943#discussion_r2015441462


##########
parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/type/DorisDDLStatementVisitor.java:
##########
@@ -1046,4 +1048,9 @@ public ASTNode visitExecuteStmt(final ExecuteStmtContext ctx) {
     public ASTNode visitDeallocate(final DeallocateContext ctx) {
         return new DorisDeallocateStatement();
     }
+    
+    @Override
+    public ASTNode visitCreateMaterializedView(final CreateMaterializedViewContext ctx) {
+        return new DorisCreateMaterializedViewStatement();

Review Comment:
   The method visitCreateMaterializedView currently creates and returns a new DorisCreateMaterializedViewStatement without extracting any details from the provided context. If specific properties are expected from the SQL context, consider processing ctx to initialize the statement accordingly.
   ```suggestion
           String viewName = ctx.viewName().getText();
           SelectStatement selectStatement = (SelectStatement) visit(ctx.selectStatement());
           return new DorisCreateMaterializedViewStatement(viewName, selectStatement);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org