You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Ivan Poot Diaz <iv...@gmail.com> on 2013/06/19 06:47:10 UTC
Module cui - Add new color
Hi all,
This patch "registrodom.patch":
This code snippet allows Auto Registration the colors to Apache OpenOffice
Drawing , ie the self-colored. Through this patch allows the user to add new
colors in the color palette without entering a name.
If the color name already exists, it is automatically assigned a number to
the name, eg
open
open4509
open0267
open8160
open1094 ...
This code I've been working in the module cui (file: tpcolor.cxx). I would
like that the community to help implement this code in AOO.
The Auto Registration of colors: I think an excellent idea as draw
integrated this functionality in AOO and allow the user to add new colors
without many's restrictions, this process could be done more quickly and
efficiently. No doubt it would be very useful in my humble opinion.
Best Regards.
Re: Module cui - Add new color
Posted by Ivan Poot Diaz <iv...@gmail.com>.
Ok.
Here is the link of the patch
https://issues.apache.org/ooo/show_bug.cgi?id=122582
Best Regards.
2013/6/24 Armin Le Grand <Ar...@me.com>
> Hi,
>
>
> On 24.06.2013 06:27, Juergen Schmidt wrote:
>
>> Am Sonntag, 23. Juni 2013 um 13:48 schrieb Andrea Pescetti:
>>
>>> On 19/06/2013 Ivan Poot Diaz wrote:
>>>
>>>> This patch "registrodom.patch":
>>>> This code snippet allows Auto Registration the colors to Apache
>>>> OpenOffice Drawing , ie the self-colored. Through this patch allows the
>>>> user to add new colors in the color palette without entering a name. ...
>>>> This code I've been working in the module cui (file: tpcolor.cxx). I
>>>> would like that the community to help implement this code in AOO.
>>>>
>>>>
>>> Hi Ivan, we didn't receive your patch: the dev mailing list strips all
>>> attachments from messages. The right way to send a patch is to create an
>>> issue at https://issues.apache.org/ooo/ and attach the patch to it
>>> (don't worry about the many other fields, we can always fix them later;
>>> but please put a description like the one you put in your e-mail and
>>> attach the patch file).
>>>
>>>
>>> be careful with patches that have influence on the UI. We should not
>> integrate such patches now at this time on front of the release.
>> Adding a single color make no sense and a consistent color scheme is
>> important. The focus should be here more on adding a custom color palette
>> as an extension.
>>
>
> I guess from the description that it's more about avoiding to ask the user
> for a unique name for the new color when entering one in the fill dialog.
> Second guess is that such a unique name gets constructed, e.g. using the
> RGB values as hex or something similar (white would be named 0xffffff). I
> thought about something similar already...
>
> If it arrives, I can have a look!
>
> Sincerely,
> Armin
>
>
>> Juergen
>>
>>> Regards,
>>> Andrea.
>>>
>>> ------------------------------**------------------------------**
>>> ---------
>>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.**apache.org<de...@openoffice.apache.org>
>>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>>
>>>
>>>
>>
>> --
> ALG
>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.**apache.org<de...@openoffice.apache.org>
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>
Re: Module cui - Add new color
Posted by Armin Le Grand <Ar...@me.com>.
Hi,
On 24.06.2013 06:27, Juergen Schmidt wrote:
> Am Sonntag, 23. Juni 2013 um 13:48 schrieb Andrea Pescetti:
>> On 19/06/2013 Ivan Poot Diaz wrote:
>>> This patch "registrodom.patch":
>>> This code snippet allows Auto Registration the colors to Apache
>>> OpenOffice Drawing , ie the self-colored. Through this patch allows the
>>> user to add new colors in the color palette without entering a name. ...
>>> This code I've been working in the module cui (file: tpcolor.cxx). I
>>> would like that the community to help implement this code in AOO.
>>>
>>
>> Hi Ivan, we didn't receive your patch: the dev mailing list strips all
>> attachments from messages. The right way to send a patch is to create an
>> issue at https://issues.apache.org/ooo/ and attach the patch to it
>> (don't worry about the many other fields, we can always fix them later;
>> but please put a description like the one you put in your e-mail and
>> attach the patch file).
>>
>>
> be careful with patches that have influence on the UI. We should not integrate such patches now at this time on front of the release.
> Adding a single color make no sense and a consistent color scheme is important. The focus should be here more on adding a custom color palette as an extension.
I guess from the description that it's more about avoiding to ask the
user for a unique name for the new color when entering one in the fill
dialog. Second guess is that such a unique name gets constructed, e.g.
using the RGB values as hex or something similar (white would be named
0xffffff). I thought about something similar already...
If it arrives, I can have a look!
Sincerely,
Armin
>
> Juergen
>> Regards,
>> Andrea.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
>>
>
>
--
ALG
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: Module cui - Add new color
Posted by Juergen Schmidt <jo...@gmail.com>.
Am Sonntag, 23. Juni 2013 um 13:48 schrieb Andrea Pescetti:
> On 19/06/2013 Ivan Poot Diaz wrote:
> > This patch "registrodom.patch":
> > This code snippet allows Auto Registration the colors to Apache
> > OpenOffice Drawing , ie the self-colored. Through this patch allows the
> > user to add new colors in the color palette without entering a name. ...
> > This code I've been working in the module cui (file: tpcolor.cxx). I
> > would like that the community to help implement this code in AOO.
> >
>
>
> Hi Ivan, we didn't receive your patch: the dev mailing list strips all
> attachments from messages. The right way to send a patch is to create an
> issue at https://issues.apache.org/ooo/ and attach the patch to it
> (don't worry about the many other fields, we can always fix them later;
> but please put a description like the one you put in your e-mail and
> attach the patch file).
>
>
be careful with patches that have influence on the UI. We should not integrate such patches now at this time on front of the release.
Adding a single color make no sense and a consistent color scheme is important. The focus should be here more on adding a custom color palette as an extension.
Juergen
>
> Regards,
> Andrea.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>
Re: Module cui - Add new color
Posted by Andrea Pescetti <pe...@apache.org>.
On 19/06/2013 Ivan Poot Diaz wrote:
> This patch "registrodom.patch":
> This code snippet allows Auto Registration the colors to Apache
> OpenOffice Drawing , ie the self-colored. Through this patch allows the
> user to add new colors in the color palette without entering a name. ...
> This code I've been working in the module cui (file: tpcolor.cxx). I
> would like that the community to help implement this code in AOO.
Hi Ivan, we didn't receive your patch: the dev mailing list strips all
attachments from messages. The right way to send a patch is to create an
issue at https://issues.apache.org/ooo/ and attach the patch to it
(don't worry about the many other fields, we can always fix them later;
but please put a description like the one you put in your e-mail and
attach the patch file).
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org