You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2006/08/29 14:17:31 UTC
[jira] Created: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
[logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
------------------------------------------------------------------------------------
Key: HARMONY-1338
URL: http://issues.apache.org/jira/browse/HARMONY-1338
Project: Harmony
Issue Type: Bug
Reporter: Alexey Varlamov
Priority: Trivial
The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
[1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1338?page=all ]
Paulex Yang reassigned HARMONY-1338:
------------------------------------
Assignee: Paulex Yang
> [logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-1338
> URL: http://issues.apache.org/jira/browse/HARMONY-1338
> Project: Harmony
> Issue Type: Bug
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Priority: Trivial
> Attachments: harmony-1338.patch
>
>
> The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
> This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1338?page=comments#action_12431558 ]
Alexey Varlamov commented on HARMONY-1338:
------------------------------------------
Thank you Paulex.
Jjust a small notice, you've added extra line:
System.out.println(t.toString());
> [logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-1338
> URL: http://issues.apache.org/jira/browse/HARMONY-1338
> Project: Harmony
> Issue Type: Bug
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Priority: Trivial
> Attachments: harmony-1338-2.patch, harmony-1338.patch
>
>
> The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
> This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1338?page=all ]
Alexey Varlamov updated HARMONY-1338:
-------------------------------------
Attachment: harmony-1338.patch
The suggested fix is to check ordinary throwable message instead.
> [logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-1338
> URL: http://issues.apache.org/jira/browse/HARMONY-1338
> Project: Harmony
> Issue Type: Bug
> Reporter: Alexey Varlamov
> Priority: Trivial
> Attachments: harmony-1338.patch
>
>
> The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
> This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1338?page=all ]
Alexey Varlamov updated HARMONY-1338:
-------------------------------------
Attachment: harmony-1338-2.patch
Better yet, just to check for thrown.toString() presence. So the later patch supersedes the first one.
> [logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-1338
> URL: http://issues.apache.org/jira/browse/HARMONY-1338
> Project: Harmony
> Issue Type: Bug
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Priority: Trivial
> Attachments: harmony-1338-2.patch, harmony-1338.patch
>
>
> The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
> This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1338?page=all ]
Paulex Yang resolved HARMONY-1338.
----------------------------------
Resolution: Fixed
Alexey, patch applied at revision r438382, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.
> [logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-1338
> URL: http://issues.apache.org/jira/browse/HARMONY-1338
> Project: Harmony
> Issue Type: Bug
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Priority: Trivial
> Attachments: harmony-1338-2.patch, harmony-1338.patch
>
>
> The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
> This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1338) [logging][test] unnecessary
dependency on implementation of j.l.Throwable.toString()
Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1338?page=all ]
Paulex Yang closed HARMONY-1338.
--------------------------------
Oops, sorry for my carelessness, have been removed at later revision.
Fix verified by Alexey.
> [logging][test] unnecessary dependency on implementation of j.l.Throwable.toString()
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-1338
> URL: http://issues.apache.org/jira/browse/HARMONY-1338
> Project: Harmony
> Issue Type: Bug
> Reporter: Alexey Varlamov
> Assigned To: Paulex Yang
> Priority: Trivial
> Attachments: harmony-1338-2.patch, harmony-1338.patch
>
>
> The org.apache.harmony.logging.tests.java.util.logging.SimpleFormatterTest.testFormat verifies that if LogRecord has a throwable associated, then localized message of the Throwable should appear in the formatted string.
> This is overkill, because there is discrepancy between j.l.Throwable.toString() specification and most implementations [1]. Anyway, this test unnecessarily depends on API contract of j.l.Throwable.getLocalizedMessage().
> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4298805
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira