You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/02 14:23:50 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #203: Changes Of Issue #9759

hanahmily commented on code in PR #203:
URL: https://github.com/apache/skywalking-banyandb/pull/203#discussion_r1011840500


##########
pkg/query/logical/index_filter.go:
##########
@@ -146,6 +146,20 @@ func parseCondition(cond *model_v1.Condition, indexRule *database_v1.IndexRule,
 			and.append(newEq(indexRule, newBytesLiteral(b)))
 		}
 		return newNot(indexRule, and), []tsdb.Entity{entity}, nil
+	case model_v1.Condition_BINARY_OP_IN:
+		bb := expr.Bytes()
+		and := newOr(len(bb))

Review Comment:
   Renam the variable and other "and" to "or".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org