You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@activemq.apache.org by "Justin Bertram (Jira)" <ji...@apache.org> on 2020/01/13 02:24:00 UTC

[jira] [Commented] (ARTEMIS-2191) Makes PostOfficeImpl::route common paths inlineable

    [ https://issues.apache.org/jira/browse/ARTEMIS-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013969#comment-17013969 ] 

Justin Bertram commented on ARTEMIS-2191:
-----------------------------------------

Looks like you did some work here, [~nigro.fra@gmail.com], but it was never committed. Is that right? Can you send another PR or close this Jira?

> Makes PostOfficeImpl::route common paths inlineable
> ---------------------------------------------------
>
>                 Key: ARTEMIS-2191
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2191
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.7.0
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Minor
>
> PostOfficeImpl::route is handling very difference cases (eg not durable/durable messages, not durable/durable queues, transactions etc etc) on the same code paths, making the code too big to be inlined when specific code paths are needed.
> The code could be refactored to allow better inlining by using smaller methods and moving away uncommon/slow path from the common one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)