You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/11/17 17:14:00 UTC

[jira] [Commented] (IMPALA-14557) TestIcebergTable.test_show_files_partition is unstable

    [ https://issues.apache.org/jira/browse/IMPALA-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038931#comment-18038931 ] 

ASF subversion and git services commented on IMPALA-14557:
----------------------------------------------------------

Commit f2243b76b56c0a29bc252cdacec8ae53de88b327 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=f2243b76b ]

IMPALA-14557: Fix flaky test_show_files_partition

TestIcebergTable.test_show_files_partition is unstable because files are
alphanumerically sorted and the order between a random UUID and
"delete-*" is not guaranteed.

This patch fix the flakiness by specifying VERIFY_IS_SUBSET and using
negative lookahead of "delete" word to detect valid Iceberg data file.

Testing:
- Loop and pass test_show_files_partition 50 times. Before, it can fail
  in less than 10 loops.

Change-Id: I6243585a5b7ab7cf7c95d5a9530ce2f2825c550e
Reviewed-on: http://gerrit.cloudera.org:8080/23680
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>


> TestIcebergTable.test_show_files_partition is unstable
> ------------------------------------------------------
>
>                 Key: IMPALA-14557
>                 URL: https://issues.apache.org/jira/browse/IMPALA-14557
>             Project: IMPALA
>          Issue Type: Task
>          Components: Test
>            Reporter: Michael Smith
>            Assignee: Riza Suminto
>            Priority: Major
>             Fix For: Impala 5.0.0
>
>
> query_test.test_iceberg.TestIcebergTable.test_show_files_partition is unstable, files or alphanumerically sorted and the order between a random UUID and "delete-*" is not guaranteed:
> {code}
> query_test/test_iceberg.py:1568: in test_show_files_partition
>     self.run_test_case('QueryTest/iceberg-show-files-partition', vector,
> common/impala_test_suite.py:918: in run_test_case
>     self.__verify_results_and_errors(vector, test_section, result, use_db)
> common/impala_test_suite.py:748: in __verify_results_and_errors
>     verify_raw_results(test_section, result, vector,
> common/test_result_verifier.py:523: in verify_raw_results
>     VERIFIER_MAP[verifier](expected, actual)
> common/test_result_verifier.py:305: in verify_query_result_is_equal
>     assert expected_results == actual_results
> E   assert Comparing QueryTestResults (expected vs actual):
> E     row_regex:'hdfs://192.168.124.1:20500/test-warehouse/test_show_files_partition_4ba085df.db/iceberg_showfiles_with_deletes/data/identity_int=1/[^d].*_data.*.parq','.*','','NONE' != 'hdfs://192.168.124.1:20500/test-warehouse/test_show_files_partition_4ba085df.db/iceberg_showfiles_with_deletes/data/identity_int=1/delete-3c451a567318c6bc-0fc90cd800000000_1846643037_data.0.parq','1.65KB','','NONE'
> E     row_regex:'hdfs://192.168.124.1:20500/test-warehouse/test_show_files_partition_4ba085df.db/iceberg_showfiles_with_deletes/data/identity_int=1/delete-.*_data.*.parq','.*','','NONE' != 'hdfs://192.168.124.1:20500/test-warehouse/test_show_files_partition_4ba085df.db/iceberg_showfiles_with_deletes/data/identity_int=1/ef4f55aa0e7a4d0c-0a81f54300000000_805080307_data.0.parq','670B','','NONE'
> E     Detailed information truncated (-7 more lines), use "-vv" to show
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org