You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Rick McGuire <ri...@gmail.com> on 2010/04/01 12:31:13 UTC

Re: svn commit: r929741 - /geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java

David,

This update is giving me a compile error on the latest trunk.  The 
OutboundResourceAdapter.isReauthenticationSupport() method returns null, 
not a nullable object type.  I checked against the latest from the 
openejb project, that that still seems to be the case.  Are you using a 
different version of that class for your local builds?

Rick

On 3/31/2010 7:01 PM, djencks@apache.org wrote:
> Author: djencks
> Date: Wed Mar 31 23:01:38 2010
> New Revision: 929741
>
> URL: http://svn.apache.org/viewvc?rev=929741&view=rev
> Log:
> GERONIMO-4360 glitch in merging annotations to ra.xml
>
> Modified:
>      geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
>
> Modified: geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java?rev=929741&r1=929740&r2=929741&view=diff
> ==============================================================================
> --- geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java (original)
> +++ geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java Wed Mar 31 23:01:38 2010
> @@ -653,7 +653,7 @@ public class ConnectorModuleBuilder impl
>                           outboundResourceAdapter = new OutboundResourceAdapter();
>                           resourceAdapter.setOutboundResourceAdapter(outboundResourceAdapter);
>                       }
> -                    if (outboundResourceAdapter.isReauthenticationSupport()) {
> +                    if (outboundResourceAdapter.isReauthenticationSupport() == null) {
>                           outboundResourceAdapter.setReauthenticationSupport(ra.reauthenticationSupport());
>                       }
>                       if (outboundResourceAdapter.getTransactionSupport() == null) {
>
>
>
>

Re: svn commit: r929741 - /geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java

Posted by David Jencks <da...@yahoo.com>.
Rick,

I had an uncommitted openejb change, now committed rev 930005.

thanks
david jencks

On Apr 1, 2010, at 3:31 AM, Rick McGuire wrote:

> David,
> 
> This update is giving me a compile error on the latest trunk.  The OutboundResourceAdapter.isReauthenticationSupport() method returns null, not a nullable object type.  I checked against the latest from the openejb project, that that still seems to be the case.  Are you using a different version of that class for your local builds?
> 
> Rick
> 
> On 3/31/2010 7:01 PM, djencks@apache.org wrote:
>> Author: djencks
>> Date: Wed Mar 31 23:01:38 2010
>> New Revision: 929741
>> 
>> URL: http://svn.apache.org/viewvc?rev=929741&view=rev
>> Log:
>> GERONIMO-4360 glitch in merging annotations to ra.xml
>> 
>> Modified:
>>     geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
>> 
>> Modified: geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java?rev=929741&r1=929740&r2=929741&view=diff
>> ==============================================================================
>> --- geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java (original)
>> +++ geronimo/server/trunk/plugins/connector-1_6/geronimo-connector-builder-1_6/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java Wed Mar 31 23:01:38 2010
>> @@ -653,7 +653,7 @@ public class ConnectorModuleBuilder impl
>>                          outboundResourceAdapter = new OutboundResourceAdapter();
>>                          resourceAdapter.setOutboundResourceAdapter(outboundResourceAdapter);
>>                      }
>> -                    if (outboundResourceAdapter.isReauthenticationSupport()) {
>> +                    if (outboundResourceAdapter.isReauthenticationSupport() == null) {
>>                          outboundResourceAdapter.setReauthenticationSupport(ra.reauthenticationSupport());
>>                      }
>>                      if (outboundResourceAdapter.getTransactionSupport() == null) {
>> 
>> 
>> 
>>   
>