You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by sr...@apache.org on 2016/02/17 02:49:25 UTC
[1/3] storm git commit: STORM-1539 - Improve Storm ACK-ing performance
Repository: storm
Updated Branches:
refs/heads/master 4a9278630 -> 40b115f1d
STORM-1539 - Improve Storm ACK-ing performance
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/d110b1f9
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/d110b1f9
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/d110b1f9
Branch: refs/heads/master
Commit: d110b1f95d8f07b8a2c825885fc6bfa94af7a705
Parents: 12ceb09
Author: Roshan Naik <ro...@hortonworks.com>
Authored: Fri Feb 12 14:57:54 2016 -0800
Committer: Roshan Naik <ro...@hortonworks.com>
Committed: Fri Feb 12 14:57:54 2016 -0800
----------------------------------------------------------------------
storm-core/src/clj/org/apache/storm/daemon/executor.clj | 6 +-----
storm-core/src/jvm/org/apache/storm/utils/Utils.java | 8 ++++++++
2 files changed, 9 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/d110b1f9/storm-core/src/clj/org/apache/storm/daemon/executor.clj
----------------------------------------------------------------------
diff --git a/storm-core/src/clj/org/apache/storm/daemon/executor.clj b/storm-core/src/clj/org/apache/storm/daemon/executor.clj
index e2380b7..e01311b 100644
--- a/storm-core/src/clj/org/apache/storm/daemon/executor.clj
+++ b/storm-core/src/clj/org/apache/storm/daemon/executor.clj
@@ -498,10 +498,6 @@
EVENTLOGGER-STREAM-ID
[component-id message-id (System/currentTimeMillis) values]))))
-(defn- bit-xor-vals
- [vals]
- (reduce bit-xor 0 vals))
-
(defmethod mk-threads :spout [executor-data task-datas initial-credentials]
(let [{:keys [storm-conf component-id worker-context transfer-fn report-error sampler open-or-prepare-was-called?]} executor-data
^ISpoutWaitStrategy spout-wait-strategy (init-spout-wait-strategy storm-conf)
@@ -589,7 +585,7 @@
(if (sampler) (System/currentTimeMillis))])
(task/send-unanchored task-data
ACKER-INIT-STREAM-ID
- [root-id (bit-xor-vals out-ids) task-id]))
+ [root-id (Utils/bitXorVals out-ids) task-id]))
(when message-id
(ack-spout-msg executor-data task-data message-id
{:stream out-stream-id :values values}
http://git-wip-us.apache.org/repos/asf/storm/blob/d110b1f9/storm-core/src/jvm/org/apache/storm/utils/Utils.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/org/apache/storm/utils/Utils.java b/storm-core/src/jvm/org/apache/storm/utils/Utils.java
index a0c0b1a..a04bb04 100644
--- a/storm-core/src/jvm/org/apache/storm/utils/Utils.java
+++ b/storm-core/src/jvm/org/apache/storm/utils/Utils.java
@@ -302,6 +302,14 @@ public class Utils {
return ret.toString();
}
+ public static long bitXorVals(List<Long> coll) {
+ long result = 0;
+ for (Long val : coll) {
+ result ^= val;
+ }
+ return result;
+ }
+
public static void sleep(long millis) {
try {
Time.sleep(millis);
[3/3] storm git commit: Added STORM-1539 to CHANGELOG.
Posted by sr...@apache.org.
Added STORM-1539 to CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/40b115f1
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/40b115f1
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/40b115f1
Branch: refs/heads/master
Commit: 40b115f1de09ac04b11bf7ef03c6fa34cadbcc20
Parents: fd42a28
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Authored: Tue Feb 16 17:48:35 2016 -0800
Committer: Sriharsha Chintalapani <ha...@hortonworks.com>
Committed: Tue Feb 16 17:48:35 2016 -0800
----------------------------------------------------------------------
CHANGELOG.md | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/40b115f1/CHANGELOG.md
----------------------------------------------------------------------
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a9ba9f0..32ed258 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,6 +16,7 @@
* STORM-1521: When using Kerberos login from keytab with multiple bolts/executors ticket is not renewed in hbase bolt.
## 1.0.0
+ * STORM-1539: Improve Storm ACK-ing performance
* STORM-1519: Storm syslog logging not confirming to RFC5426 3.1
* STORM-1520: Nimbus Clojure/Zookeeper issue ("stateChanged" method not found)
* STORM-1531: Junit and mockito dependencies need to have correct scope defined in storm-elasticsearch pom.xml
[2/3] storm git commit: Merge branch 'STORM-1539' of
http://github.com/roshannaik/storm into STORM-1539
Posted by sr...@apache.org.
Merge branch 'STORM-1539' of http://github.com/roshannaik/storm into STORM-1539
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/fd42a28e
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/fd42a28e
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/fd42a28e
Branch: refs/heads/master
Commit: fd42a28edc2d8bfd608d6283106311809e135acc
Parents: 4a92786 d110b1f
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Authored: Tue Feb 16 17:34:26 2016 -0800
Committer: Sriharsha Chintalapani <ha...@hortonworks.com>
Committed: Tue Feb 16 17:34:26 2016 -0800
----------------------------------------------------------------------
storm-core/src/clj/org/apache/storm/daemon/executor.clj | 6 +-----
storm-core/src/jvm/org/apache/storm/utils/Utils.java | 8 ++++++++
2 files changed, 9 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/fd42a28e/storm-core/src/clj/org/apache/storm/daemon/executor.clj
----------------------------------------------------------------------