You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by prateekm <gi...@git.apache.org> on 2018/10/11 21:05:28 UTC

[GitHub] samza pull request #708: System and Stream Descriptor API cleanup.

GitHub user prateekm opened a pull request:

    https://github.com/apache/samza/pull/708

    System and Stream Descriptor API cleanup.

    Major changes:
    1. Made withPhysicalName(String) a protected method in StreamDescriptor. 
    The primary reason to set the physical name is to use stream names with special characters in them, which streamId doesn't support. This change is to make it so that the physical name setter should only be exposed by systems where it means something useful - like HDFS.
    2. Renamed some methods in StreamDescriptor for clarity.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prateekm/samza stream-descriptor-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #708
    
----
commit 0caa8506832ae51d5d2eef5155327ae917191cb7
Author: Prateek Maheshwari <pm...@...>
Date:   2018-10-11T21:01:42Z

    System and Stream Descriptor API cleanup.

----


---

[GitHub] samza pull request #708: System and Stream Descriptor API cleanup.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/samza/pull/708


---