You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Markus Wiederkehr <ma...@gmail.com> on 2009/04/21 17:38:55 UTC
Re: [jira] Commented: (JAMES-899) RemoteDelivery sends a message
again and again if transport.close() throws a MessagingException
Should I use the same "new StringBuffer(256).append().." mechanism
found everywhere else in RemoteDelivery? I guess it's only about the
initial size of 256 characters?
And where do I have to commit the patch? james/server/branches/v2.3/
and james/server/trunk/mailets-function/?
Or does someone else want to commit?
Markus
On Tue, Apr 21, 2009 at 5:13 PM, Markus Wiederkehr (JIRA)
<se...@james.apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/JAMES-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701174#action_12701174 ]
>
> Markus Wiederkehr commented on JAMES-899:
> -----------------------------------------
>
> Updated patch to include the mail recipients and the detail message of the MessagingException in the log message.
>
>> RemoteDelivery sends a message again and again if transport.close() throws a MessagingException
>> -----------------------------------------------------------------------------------------------
>>
>> Key: JAMES-899
>> URL: https://issues.apache.org/jira/browse/JAMES-899
>> Project: JAMES Server
>> Issue Type: Bug
>> Affects Versions: 2.3.1
>> Reporter: Markus Wiederkehr
>> Assignee: Markus Wiederkehr
>> Fix For: 2.3.2
>>
>> Attachments: james-889.patch
>>
>>
>> Some mail servers close the TCP connection as soon as they have received and responded to the terminating dot of the DATA command. As a consequence JavaMail throws a MessagingException in SMTPTransport.close() and RemoteDelivery thinks it has to send the message again (and again).
>> Even though the server's behaviour is not standard compliant (see RFC 5321 section 4.1.1.10.) the message should still be considered to be delivered successfully because the error occurred after the mail transaction has been completed (RFC 5321 section 3.3).
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-899) RemoteDelivery sends a message
again and again if transport.close() throws a MessagingException
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Tue, Apr 21, 2009 at 5:15 PM, Stefano Bagnara <ap...@bago.org> wrote:
> Markus Wiederkehr ha scritto:
>> Should I use the same "new StringBuffer(256).append().." mechanism
>> found everywhere else in RemoteDelivery? I guess it's only about the
>> initial size of 256 characters?
>
> I'm a fan of simple string concatenation, because I believe in javac ;-)
this is a little controversial
on JDK1.5, string concatination is quicker than string buffer so
better to use StringBuilder on trunk and StringBuffer on 2.x
>> And where do I have to commit the patch? james/server/branches/v2.3/
>> and james/server/trunk/mailets-function/?
>
> trunk!
> And maybe this should also be backported to v2.3, +1 to backport it as
> it is a "major" bug (leading to multiple deliveries).
+1
>> Or does someone else want to commit?
>
> Please do it.
+1
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: [jira] Commented: (JAMES-899) RemoteDelivery sends a message
again and again if transport.close() throws a MessagingException
Posted by Stefano Bagnara <ap...@bago.org>.
Markus Wiederkehr ha scritto:
> Should I use the same "new StringBuffer(256).append().." mechanism
> found everywhere else in RemoteDelivery? I guess it's only about the
> initial size of 256 characters?
I'm a fan of simple string concatenation, because I believe in javac ;-)
> And where do I have to commit the patch? james/server/branches/v2.3/
> and james/server/trunk/mailets-function/?
trunk!
And maybe this should also be backported to v2.3, +1 to backport it as
it is a "major" bug (leading to multiple deliveries).
> Or does someone else want to commit?
Please do it. I'm not even "checked out" ATM :-(
Thank you,
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org