You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2021/03/18 06:40:38 UTC

[dubbo] branch 3.0-preview updated: create reference proxy after export service in DubboBootstrap (#7402)

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch 3.0-preview
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/3.0-preview by this push:
     new 1ec8953  create reference proxy after export service in DubboBootstrap (#7402)
1ec8953 is described below

commit 1ec89537edb1ef77977b5c77a2ba4fd8d3a9c77f
Author: Gong Dewei <ky...@qq.com>
AuthorDate: Thu Mar 18 14:40:18 2021 +0800

    create reference proxy after export service in DubboBootstrap (#7402)
---
 .../org/apache/dubbo/config/spring/ReferenceBeanManager.java  | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBeanManager.java b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBeanManager.java
index 122440c..83765f4 100644
--- a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBeanManager.java
+++ b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBeanManager.java
@@ -25,7 +25,6 @@ import org.apache.dubbo.config.ReferenceConfig;
 import org.apache.dubbo.config.bootstrap.DubboBootstrap;
 import org.apache.dubbo.config.spring.beans.factory.annotation.AnnotationPropertyValuesAdapter;
 import org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceBeanBuilder;
-import org.apache.dubbo.config.utils.ReferenceConfigCache;
 import org.springframework.beans.BeansException;
 import org.springframework.beans.MutablePropertyValues;
 import org.springframework.beans.PropertyValue;
@@ -73,7 +72,7 @@ public class ReferenceBeanManager implements ApplicationContextAware {
 
         // if add reference after prepareReferenceBeans(), should init it immediately.
         if (initialized) {
-            initReferenceBean(referenceBean, true);
+            initReferenceBean(referenceBean);
         }
     }
 
@@ -107,7 +106,7 @@ public class ReferenceBeanManager implements ApplicationContextAware {
     public void prepareReferenceBeans() throws Exception {
         initialized = true;
         for (ReferenceBean referenceBean : getReferences()) {
-            initReferenceBean(referenceBean, false);
+            initReferenceBean(referenceBean);
         }
     }
 
@@ -117,7 +116,7 @@ public class ReferenceBeanManager implements ApplicationContextAware {
      * @param referenceBean
      * @throws Exception
      */
-    private void initReferenceBean(ReferenceBean referenceBean, boolean canCreateProxy) throws Exception {
+    private void initReferenceBean(ReferenceBean referenceBean) throws Exception {
 
         if (referenceBean.getReferenceConfig() != null) {
             return;
@@ -146,10 +145,6 @@ public class ReferenceBeanManager implements ApplicationContextAware {
         // register ReferenceConfig
         DubboBootstrap.getInstance().reference(referenceConfig);
 
-        //TODO add after DubboBootstrap is started
-        if (canCreateProxy && referenceConfig.shouldInit()) {
-            ReferenceConfigCache.getCache().get(referenceConfig);
-        }
     }
 
     private void resolvePlaceholders(Map<String, Object> referenceProps, PropertyResolver propertyResolver) {