You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@atlas.apache.org by rm...@apache.org on 2020/01/14 22:30:21 UTC

[atlas] branch master updated: ATLAS-3581:HBase hook converts qualifiedName to lowercase for namespace, table, column-family and column

This is an automated email from the ASF dual-hosted git repository.

rmani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/atlas.git


The following commit(s) were added to refs/heads/master by this push:
     new 2d4edf8  ATLAS-3581:HBase hook converts qualifiedName to lowercase for namespace, table, column-family and column
2d4edf8 is described below

commit 2d4edf87728b45b6498e2d7772d87829d7079ef8
Author: Ramesh Mani <ra...@gmail.com>
AuthorDate: Fri Jan 10 11:17:39 2020 -0800

    ATLAS-3581:HBase hook converts qualifiedName to lowercase for namespace, table, column-family and column
    
    Signed-off-by: Ramesh Mani <ra...@gmail.com>
---
 .../java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java     |  6 +++---
 .../main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java   | 10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java b/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
index 26be9b3..0ab06f2 100644
--- a/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
+++ b/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
@@ -316,7 +316,7 @@ public class HBaseAtlasHook extends AtlasHook {
         if (metadataNamespace == null || nameSpace == null || tableName == null || columnFamily == null) {
             return null;
         } else {
-            return String.format(HBASE_COLUMN_FAMILY_QUALIFIED_NAME_FORMAT, nameSpace.toLowerCase(), stripNameSpace(tableName.toLowerCase()), columnFamily.toLowerCase(), metadataNamespace);
+            return String.format(HBASE_COLUMN_FAMILY_QUALIFIED_NAME_FORMAT, nameSpace, stripNameSpace(tableName), columnFamily, metadataNamespace);
         }
     }
 
@@ -332,7 +332,7 @@ public class HBaseAtlasHook extends AtlasHook {
         if (metadataNamespace == null || nameSpace == null || tableName == null) {
             return null;
         } else {
-            return String.format(HBASE_TABLE_QUALIFIED_NAME_FORMAT, nameSpace.toLowerCase(), stripNameSpace(tableName.toLowerCase()), metadataNamespace);
+            return String.format(HBASE_TABLE_QUALIFIED_NAME_FORMAT, nameSpace, stripNameSpace(tableName), metadataNamespace);
         }
     }
 
@@ -347,7 +347,7 @@ public class HBaseAtlasHook extends AtlasHook {
         if (metadataNamespace == null || nameSpace == null) {
             return null;
         } else {
-            return String.format(HBASE_NAMESPACE_QUALIFIED_NAME, nameSpace.toLowerCase(), metadataNamespace);
+            return String.format(HBASE_NAMESPACE_QUALIFIED_NAME, nameSpace, metadataNamespace);
         }
     }
 
diff --git a/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java b/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
index fde70f1..f012664 100644
--- a/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
+++ b/addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java
@@ -652,8 +652,8 @@ public class HBaseBridge {
      * @return Unique qualified name to identify the Table instance in Atlas.
      */
     private static String getColumnFamilyQualifiedName(String metadataNamespace, String nameSpace, String tableName, String columnFamily) {
-        tableName = stripNameSpace(tableName.toLowerCase());
-        return String.format(HBASE_COLUMN_FAMILY_QUALIFIED_NAME_FORMAT, nameSpace.toLowerCase(), tableName, columnFamily.toLowerCase(), metadataNamespace);
+        tableName = stripNameSpace(tableName);
+        return String.format(HBASE_COLUMN_FAMILY_QUALIFIED_NAME_FORMAT, nameSpace, tableName, columnFamily, metadataNamespace);
     }
 
     /**
@@ -664,8 +664,8 @@ public class HBaseBridge {
      * @return Unique qualified name to identify the Table instance in Atlas.
      */
     private static String getTableQualifiedName(String metadataNamespace, String nameSpace, String tableName) {
-        tableName = stripNameSpace(tableName.toLowerCase());
-        return String.format(HBASE_TABLE_QUALIFIED_NAME_FORMAT, nameSpace.toLowerCase(), tableName, metadataNamespace);
+        tableName = stripNameSpace(tableName);
+        return String.format(HBASE_TABLE_QUALIFIED_NAME_FORMAT, nameSpace, tableName, metadataNamespace);
     }
 
     /**
@@ -675,7 +675,7 @@ public class HBaseBridge {
      * @return Unique qualified name to identify the HBase NameSpace instance in Atlas.
      */
     private static String getNameSpaceQualifiedName(String metadataNamespace, String nameSpace) {
-        return String.format(HBASE_NAMESPACE_QUALIFIED_NAME, nameSpace.toLowerCase(), metadataNamespace);
+        return String.format(HBASE_NAMESPACE_QUALIFIED_NAME, nameSpace, metadataNamespace);
     }
 
     private static String stripNameSpace(String tableName){