You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/09/16 19:01:57 UTC

[jira] Created: (WINK-189) Change for continuedSearchPolicy and caching of root resources in registry

Change for continuedSearchPolicy and caching of root resources in registry
--------------------------------------------------------------------------

                 Key: WINK-189
                 URL: https://issues.apache.org/jira/browse/WINK-189
             Project: Wink
          Issue Type: Improvement
          Components: Common
    Affects Versions: 0.2
            Reporter: Bryant Luk
            Assignee: Bryant Luk
             Fix For: 0.2


There are two changes that are related to the FindRootResourceHandler and the ResourceRegistry.

First, getMatchingRootResources() matches against many root resources. When continued search policy is not used however, it should be able to return the first match immediately.  Slight method addition to add that.

Second, the "matching" root resources results can be cached based on the URI.

I'll attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WINK-189) Change for continuedSearchPolicy and caching of root resources in registry

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk resolved WINK-189.
-----------------------------

    Resolution: Fixed

Patch applied.  Thanks to Doug Larson for suggestions and the performance profiling work.

> Change for continuedSearchPolicy and caching of root resources in registry
> --------------------------------------------------------------------------
>
>                 Key: WINK-189
>                 URL: https://issues.apache.org/jira/browse/WINK-189
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.2
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.2
>
>         Attachments: WINK-189.patch
>
>
> There are two changes that are related to the FindRootResourceHandler and the ResourceRegistry.
> First, getMatchingRootResources() matches against many root resources. When continued search policy is not used however, it should be able to return the first match immediately.  Slight method addition to add that.
> Second, the "matching" root resources results can be cached based on the URI.
> I'll attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WINK-189) Change for continuedSearchPolicy and caching of root resources in registry

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk closed WINK-189.
---------------------------


> Change for continuedSearchPolicy and caching of root resources in registry
> --------------------------------------------------------------------------
>
>                 Key: WINK-189
>                 URL: https://issues.apache.org/jira/browse/WINK-189
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.2
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.2
>
>         Attachments: WINK-189.patch
>
>
> There are two changes that are related to the FindRootResourceHandler and the ResourceRegistry.
> First, getMatchingRootResources() matches against many root resources. When continued search policy is not used however, it should be able to return the first match immediately.  Slight method addition to add that.
> Second, the "matching" root resources results can be cached based on the URI.
> I'll attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WINK-189) Change for continuedSearchPolicy and caching of root resources in registry

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756772#action_12756772 ] 

Hudson commented on WINK-189:
-----------------------------

Integrated in Wink-Trunk-JDK1.5 #161 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/161/])
    Performance improvement to FindRootResourceHandler

See []


> Change for continuedSearchPolicy and caching of root resources in registry
> --------------------------------------------------------------------------
>
>                 Key: WINK-189
>                 URL: https://issues.apache.org/jira/browse/WINK-189
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.2
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.2
>
>         Attachments: WINK-189.patch
>
>
> There are two changes that are related to the FindRootResourceHandler and the ResourceRegistry.
> First, getMatchingRootResources() matches against many root resources. When continued search policy is not used however, it should be able to return the first match immediately.  Slight method addition to add that.
> Second, the "matching" root resources results can be cached based on the URI.
> I'll attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WINK-189) Change for continuedSearchPolicy and caching of root resources in registry

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk updated WINK-189:
----------------------------

    Attachment: WINK-189.patch

This patch also moves the acquiring of the reader lock to the method which I think in a very rare instance may have produced something slightly different (assertSorted() call finished, reader lock unlocked, resource added, getMatchingRootResources called()).

> Change for continuedSearchPolicy and caching of root resources in registry
> --------------------------------------------------------------------------
>
>                 Key: WINK-189
>                 URL: https://issues.apache.org/jira/browse/WINK-189
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.2
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.2
>
>         Attachments: WINK-189.patch
>
>
> There are two changes that are related to the FindRootResourceHandler and the ResourceRegistry.
> First, getMatchingRootResources() matches against many root resources. When continued search policy is not used however, it should be able to return the first match immediately.  Slight method addition to add that.
> Second, the "matching" root resources results can be cached based on the URI.
> I'll attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WINK-189) Change for continuedSearchPolicy and caching of root resources in registry

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk updated WINK-189:
----------------------------

    Patch Info: [Patch Available]

> Change for continuedSearchPolicy and caching of root resources in registry
> --------------------------------------------------------------------------
>
>                 Key: WINK-189
>                 URL: https://issues.apache.org/jira/browse/WINK-189
>             Project: Wink
>          Issue Type: Improvement
>          Components: Common
>    Affects Versions: 0.2
>            Reporter: Bryant Luk
>            Assignee: Bryant Luk
>             Fix For: 0.2
>
>         Attachments: WINK-189.patch
>
>
> There are two changes that are related to the FindRootResourceHandler and the ResourceRegistry.
> First, getMatchingRootResources() matches against many root resources. When continued search policy is not used however, it should be able to return the first match immediately.  Slight method addition to add that.
> Second, the "matching" root resources results can be cached based on the URI.
> I'll attach a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.