[GitHub] [james-project] chibenwa commented on a diff in pull request #1277: JAMES-3830 Jmap Quota/query

[GitBox <gi...@apache.org>]

chibenwa commented on code in PR #1277:
URL: https://github.com/apache/james-project/pull/1277#discussion_r1010079430


##########
server/protocols/jmap-rfc-8621/doc/specs/spec/quotas/quota.mdown:
##########
@@ -79,10 +79,9 @@ A **FilterCondition** object has the following properties, any of which may be o
 A Quota object matches the FilterCondition if and only if all of the given conditions match. If zero properties are
 specified, it is automatically true for all objects.
 
-The following Quota properties MUST be supported for sorting:
+The FilterOperator (AND/OR/NOT) is not supported
 
-* **name**
-* **used**
+The following properties are not supported: sort, position, anchor, anchorOffset, limit, calculateTotal.

Review Comment:
   You modified the spec here! That is bad!
   
   ```
   The following Quota properties MUST be supported for sorting:
   
   * **name**
   * **used**
   
   > :warning:
   > Not implemented
   > The following properties are not supported: sort, position, anchor, anchorOffset, limit, calculateTotal.
   ```
   
   BTW we should likely support the `sort` option with the two mentionned properties...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org