[GitHub] [ozone] ChenSammi commented on a change in pull request #2243: HDDS-5219. Limit number of bad volumes by dfs.datanode.failed.volumes.tolerated

[GitBox <gi...@apache.org>]

ChenSammi commented on a change in pull request #2243:
URL: https://github.com/apache/ozone/pull/2243#discussion_r634964960



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/MutableVolumeSet.java
##########
@@ -522,6 +539,19 @@ private void stopDiskChecker() {
     return ImmutableMap.copyOf(volumeStateMap);
   }
 
+  public boolean hasEnoughVolumes() {
+    int maxVolumeFailuresTolerated = conf.getInt(
+        DFSConfigKeysLegacy.DFS_DATANODE_FAILED_VOLUMES_TOLERATED_KEY,

Review comment:
       DFSConfigKeysLegacy is a deprecated Class.  Since Ozone is spinned out from Hadoop, as a new project, we should avoid use HDFS configuration key anymore.  We can define a similar key for Ozone. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org