You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/08/08 15:57:08 UTC

mesos git commit: Added `-Wsign-compare` to global compiler flags.

Repository: mesos
Updated Branches:
  refs/heads/master d95fba4c5 -> 3a2a68522


Added `-Wsign-compare` to global compiler flags.

Mesos already builds with the `-Wall` and `-Werror` flags.
However, different compilers have different sets of checks for `-Wall`.

This change explicitly adds the `-Wsign-compare` warning flag that is
present in GCC's `-Wall`, but not in Clang.

Review: https://reviews.apache.org/r/50774/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3a2a6852
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3a2a6852
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3a2a6852

Branch: refs/heads/master
Commit: 3a2a68522bb39473c9ee62fd8455fa8f24f1d2b1
Parents: d95fba4
Author: Joseph Wu <jo...@mesosphere.io>
Authored: Fri Aug 5 14:10:29 2016 +0200
Committer: Michael Park <mp...@apache.org>
Committed: Mon Aug 8 17:40:16 2016 +0200

----------------------------------------------------------------------
 src/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/3a2a6852/src/Makefile.am
----------------------------------------------------------------------
diff --git a/src/Makefile.am b/src/Makefile.am
index 1a9b083..39e3199 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -99,7 +99,7 @@ AM_LIBS = $(PTHREAD_LIBS)
 
 # Setup CPPFLAGS that are used for most source files.
 MESOS_CPPFLAGS = $(AM_CPPFLAGS)
-MESOS_CPPFLAGS += -Wall -Werror
+MESOS_CPPFLAGS += -Wall -Werror -Wsign-compare
 MESOS_CPPFLAGS += -DLIBDIR=\"$(libdir)\"
 MESOS_CPPFLAGS += -DPKGLIBEXECDIR=\"$(pkglibexecdir)\"
 MESOS_CPPFLAGS += -DPKGDATADIR=\"$(pkgdatadir)\"