You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Ted Kirby (JIRA)" <ji...@apache.org> on 2007/06/25 21:42:25 UTC
[jira] Created: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Remove hard-coded Geronimo name from launch console message and tool-tip
------------------------------------------------------------------------
Key: GERONIMODEVTOOLS-171
URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
Project: Geronimo-Devtools
Issue Type: Improvement
Affects Versions: 2.0
Reporter: Ted Kirby
Replace:
console=Geronimo Console
consoleTooltip=Apache Geronimo Console
with:
console={0} Console
consoleTooltip={0} Console
in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Sachin Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509624 ]
Sachin Patel commented on GERONIMODEVTOOLS-171:
-----------------------------------------------
We'll probably need a trivial extension point for this to check for supported servers to add this context menu action.
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0
> Reporter: Ted Kirby
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMODEVTOOLS-171:
-------------------------------------------
Fix Version/s: 2.0.x
Affects Version/s: (was: 2.0)
2.0.x
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0.x
> Reporter: Ted Kirby
> Assignee: Tim McConnell
> Fix For: 2.0.x
>
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625435#action_12625435 ]
Ted Kirby commented on GERONIMODEVTOOLS-171:
--------------------------------------------
This patch was actually applied with GERONIMODEVTOOLS-341. Sachin's comment remains valid.
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0.x
> Reporter: Ted Kirby
> Assignee: Tim McConnell
> Fix For: 2.1.3
>
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMODEVTOOLS-171) Add extension point to
remove hard-coded org.apache.geronimo name from launch console action check
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby resolved GERONIMODEVTOOLS-171.
----------------------------------------
Resolution: Fixed
Assignee: Ted Kirby (was: Tim McConnell)
Fixed in Rev 688899
Also:
put launch console before launch support in popup menu
configure support URL in plugin.xml extension point, not Messages.properties
> Add extension point to remove hard-coded org.apache.geronimo name from launch console action check
> --------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0.x
> Reporter: Ted Kirby
> Assignee: Ted Kirby
> Fix For: 2.1.3
>
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMODEVTOOLS-171:
-------------------------------------------
Assignee: Tim McConnell
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0
> Reporter: Ted Kirby
> Assignee: Tim McConnell
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby updated GERONIMODEVTOOLS-171:
---------------------------------------
Component/s: eclipse-plugin
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0
> Reporter: Ted Kirby
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-171) Add extension point to
remove hard-coded org.apache.geronimo name from launch console action check
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby updated GERONIMODEVTOOLS-171:
---------------------------------------
Summary: Add extension point to remove hard-coded org.apache.geronimo name from launch console action check (was: Remove hard-coded Geronimo name from launch console message and tool-tip)
re-title JIRA to properly reflect remaining work.
> Add extension point to remove hard-coded org.apache.geronimo name from launch console action check
> --------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0.x
> Reporter: Ted Kirby
> Assignee: Tim McConnell
> Fix For: 2.1.3
>
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby updated GERONIMODEVTOOLS-171:
---------------------------------------
Attachment: GD-171.patch
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Affects Versions: 2.0
> Reporter: Ted Kirby
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-171) Remove hard-coded Geronimo
name from launch console message and tool-tip
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated GERONIMODEVTOOLS-171:
-------------------------------------------
Fix Version/s: (was: 2.0.x)
2.1.x
> Remove hard-coded Geronimo name from launch console message and tool-tip
> ------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-171
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-171
> Project: Geronimo-Devtools
> Issue Type: Improvement
> Components: eclipse-plugin
> Affects Versions: 2.0.x
> Reporter: Ted Kirby
> Assignee: Tim McConnell
> Fix For: 2.1.x
>
> Attachments: GD-171.patch
>
>
> Replace:
> console=Geronimo Console
> consoleTooltip=Apache Geronimo Console
> with:
> console={0} Console
> consoleTooltip={0} Console
> in eclipse-plugin\plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\internal\Messages.properties, and allow the server name to be determined by server.getName().
> This allows for an extensible approach, for servers based on Geronimo. No change is required to support other servers.
> In this particular case, plugins\org.apache.geronimo.st.ui\src\org\apache\geronimo\st\ui\actions\LaunchGeronimoConsoleAction.G_SERVER_PREFIX is hard-coded to "org.apache.geronimo". It would be nice if this could be paramterized in some fashion to avoid having to replace the class in its entirety, just to change this value to determine if the "Launch {ServerName} Console" menu item should be activated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.