[GitHub] [airflow] potiuk commented on a change in pull request #19014: Fix Cloud SQL system tests

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #19014:
URL: https://github.com/apache/airflow/pull/19014#discussion_r744308801



##########
File path: tests/providers/google/cloud/operators/test_cloud_sql_system.py
##########
@@ -34,27 +35,98 @@
 from tests.test_utils.gcp_system_helpers import CLOUD_DAG_FOLDER, GoogleSystemTest, provide_gcp_context
 
 GCP_PROJECT_ID = os.environ.get('GCP_PROJECT_ID', 'project-id')
+CLOUD_SQL_BUCKET_NAME = os.environ.get('CLOUD_SQL_BUCKET_NAME', 'INVALID BUCKET NAME')
 
 SQL_QUERY_TEST_HELPER = CloudSqlQueryTestHelper()
 
 
+@pytest.fixture(scope='class')
+def env_patch():
+    """
+    A convenient fixture for environment variables patching.
+    All modifications will be undone after the requesting test class has finished.
+    """
+    from _pytest.monkeypatch import MonkeyPatch
+    mpatch = MonkeyPatch()

Review comment:
       I think it's good to merge. I know @deedmitrij works on automation and having the change going in this direction is an improvement (and cloud SQL is VERY annoying for system tests so any improvement there is good).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org