You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pa...@apache.org on 2013/01/15 17:36:01 UTC

[2/2] git commit: WICKET-4973: fix ArrayIndexOutOfBoundsException when windowsize == 0

Updated Branches:
  refs/heads/master 0b8a7ad32 -> 46e0e5799


WICKET-4973: fix ArrayIndexOutOfBoundsException when windowsize == 0


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/46e0e579
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/46e0e579
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/46e0e579

Branch: refs/heads/master
Commit: 46e0e57999fc03741921d10b75b089cafea3b860
Parents: 7ebc98f
Author: Emond Papegaaij <em...@topicus.nl>
Authored: Tue Jan 15 17:34:36 2013 +0100
Committer: Emond Papegaaij <em...@topicus.nl>
Committed: Tue Jan 15 17:34:36 2013 +0100

----------------------------------------------------------------------
 .../protocol/http/AbstractRequestLogger.java       |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/46e0e579/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
index 51e2083..b3b0ffe 100644
--- a/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
+++ b/wicket-core/src/main/java/org/apache/wicket/protocol/http/AbstractRequestLogger.java
@@ -182,7 +182,7 @@ public abstract class AbstractRequestLogger implements IRequestLogger
 	 */
 	private boolean hasBufferRolledOver()
 	{
-		return requestWindow[requestWindow.length - 1] != null;
+		return requestWindow.length > 0 && requestWindow[requestWindow.length - 1] != null;
 	}
 
 	@Override
@@ -224,7 +224,8 @@ public abstract class AbstractRequestLogger implements IRequestLogger
 			requestdata.setSessionInfo(sessionInfo);
 
 			long sizeInBytes = -1;
-			if (Application.exists() && Application.get().getRequestLoggerSettings().getRecordSessionSize())
+			if (Application.exists() &&
+				Application.get().getRequestLoggerSettings().getRecordSessionSize())
 			{
 				try
 				{
@@ -531,8 +532,8 @@ public abstract class AbstractRequestLogger implements IRequestLogger
 		if (Application.exists())
 		{
 			requestsWindowSize = Application.get()
-					.getRequestLoggerSettings()
-					.getRequestsWindowSize();
+				.getRequestLoggerSettings()
+				.getRequestsWindowSize();
 		}
 		return requestsWindowSize;
 	}