You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "BryanMLima (via GitHub)" <gi...@apache.org> on 2023/08/15 15:22:52 UTC
[GitHub] [cloudstack] BryanMLima commented on pull request #7799: engine/schema: fix duplicated guest OSes in 4.18.0.0
BryanMLima commented on PR #7799:
URL: https://github.com/apache/cloudstack/pull/7799#issuecomment-1679122389
@DaanHoogland I manually tested this patch. I have some concerns about hiding some Guest OS.
Root Admins still have access to the duplicate mappings, when I tried to register a new template, or edit one, the duplicate entries were still listed. There are scenarios that Root Admin accounts register templates for the end user; thus, it does not solve for this case.
Overall, I do not think the `forDisplay` parameter is necessary, at least not for solving the issue at hand. In the method `mergeDuplicates` it should mark the duplicate entries as removed, instead of hiding it. The mappings are already copied, thus, this approach should not cause any problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org