You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/03 11:52:38 UTC
[GitHub] [bookkeeper] Shoothzj opened a new pull request #3175: [build] support apple m1 build
Shoothzj opened a new pull request #3175:
URL: https://github.com/apache/bookkeeper/pull/3175
### Motivation
Support apple m1 `mvn clean package -DskipTests`
### Changes
- add profile for apple m1 using different `aol.properties` based on https://github.com/maven-nar/nar-maven-plugin/pull/382
- bump lombok to 1.18.22 to support jdk17 package. I think that it was mis-reverted by #3130(the gradle is now 1.18.22) and it doesn't worth open a new pr. Please point out if I am wrong :)
### Tests
test on my apple m1 mbp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3175: [build] support apple m1 build
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #3175:
URL: https://github.com/apache/bookkeeper/pull/3175#issuecomment-1086859399
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #3175: [build] support apple m1 build
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on a change in pull request #3175:
URL: https://github.com/apache/bookkeeper/pull/3175#discussion_r841218157
##########
File path: pom.xml
##########
@@ -1191,6 +1191,18 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>mac-apple-silicon</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ </activation>
+ <properties>
+ <nar.aolProperties>${project.build.directory}/../src/apple_m1_aol.properties</nar.aolProperties>
Review comment:
Why not just `src/apple..` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3175: [build] support apple m1 build
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #3175:
URL: https://github.com/apache/bookkeeper/pull/3175#issuecomment-1086884945
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on a change in pull request #3175: [build] support apple m1 build
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #3175:
URL: https://github.com/apache/bookkeeper/pull/3175#discussion_r841218622
##########
File path: pom.xml
##########
@@ -1191,6 +1191,18 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>mac-apple-silicon</id>
+ <activation>
+ <os>
+ <family>mac</family>
+ <arch>aarch64</arch>
+ </os>
+ </activation>
+ <properties>
+ <nar.aolProperties>${project.build.directory}/../src/apple_m1_aol.properties</nar.aolProperties>
Review comment:
@nicoloboschi Great! Fixed, I don't that way before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org