[arrow] branch master updated: ARROW-2787: [Python] Fix Cython usage instructions

[ap...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new faf16be  ARROW-2787: [Python] Fix Cython usage instructions
faf16be is described below

commit faf16bef14ce7a3b8642846ee2ce8d3a85349f24
Author: Antoine Pitrou <an...@python.org>
AuthorDate: Tue Jul 17 15:55:31 2018 +0200

    ARROW-2787: [Python] Fix Cython usage instructions
    
    It is necessary to compile a C++ Cython extension with the same ABI as that used to compile Arrow, otherwise mysterious failures may ensue.
    
    Author: Antoine Pitrou <an...@python.org>
    
    Closes #2276 from pitrou/ARROW-2787-cython-abi and squashes the following commits:
    
    2c40bef <Antoine Pitrou> ARROW-2787:  Fix Cython usage instructions
---
 python/doc/source/extending.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/python/doc/source/extending.rst b/python/doc/source/extending.rst
index 4a35898..a471fb3 100644
--- a/python/doc/source/extending.rst
+++ b/python/doc/source/extending.rst
@@ -339,7 +339,10 @@ To build this module, you will need a slightly customized ``setup.py`` file
         ext.include_dirs.append(np.get_include())
         ext.include_dirs.append(pa.get_include())
         ext.libraries.extend(pa.get_libraries())
-        ext.library_dirs.append(pa.get_library_dirs())
+        ext.library_dirs.extend(pa.get_library_dirs())
+        # Try uncommenting the following line on Linux if you otherwise
+        # get weird linker errors or runtime crashes
+        #ext.define_macros.append(("_GLIBCXX_USE_CXX11_ABI", "0"))
 
     setup(
         ext_modules=ext_modules,