You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/02 05:15:34 UTC

[GitHub] [spark] cloud-fan commented on issue #26684: [WIP][SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables.

cloud-fan commented on issue #26684: [WIP][SPARK-30001][SQL] ResolveRelations should handle both V1 and V2 tables.
URL: https://github.com/apache/spark/pull/26684#issuecomment-560234551
 
 
   1. `ResolveRelations` should only resolve session catalog references, and `ResolveTables` should resolve only non-session catalog references using the same extractors. (I think @cloud-fan also suggested this)
   2. `ResolveRelations` should use the `V2SessionCatalog` to look up a relation and should only convert to v1 if it returns `V1Table`.
   
   This is also what I suggested with option 2. Also agree that we should fix view creation later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org