[GitHub] [spark] cloud-fan commented on a change in pull request #32587: [SPARK-35440][SQL] Add function type to `ExpressionInfo` for UDF

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32587:
URL: https://github.com/apache/spark/pull/32587#discussion_r636747397



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java
##########
@@ -42,14 +42,17 @@
  * `group()` describes the category that the expression belongs to. The valid value is
  * "agg_funcs", "array_funcs", "datetime_funcs", "json_funcs", "map_funcs" and "window_funcs".
  *
+ * `functionType()` describe the type of the function. The valid value is "built-in", "hive",
+ * "python_udf", "scala_udf", "java_udf".

Review comment:
       function type may sounds like scalar/aggregate/table function etc.
   
   I don't have a good idea now, maybe `source`? cc @HyukjinKwon 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org