You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Thilina Gunarathne <cs...@gmail.com> on 2007/06/23 14:30:44 UTC

Are we making useSeparateListener "default" if the user has given a replyTo address [was:Re: svn commit: r547986 - in /webservices/axis2/trunk/java/modules: adb/src/org/apache/axis2/rpc/receivers/RPCMessageReceiver.java kernel/src/org/apache/axis2/de

Hi,
> fixing the issue.
hmm... Fixing which issue :)...

>webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/description/OutInAxisOperation.java
Sat Jun 16 14:24:15 2007
> @@ -189,6 +189,10 @@
>                  useAsync = useAsyncOption.booleanValue();
>              }
>          }
> +        EndpointReference replyTo = mc.getReplyTo();
> +        if(replyTo!=null&&!replyTo.hasAnonymousAddress()){
> +            useAsync = true;
> +        }
It seems with the above change Axis2 defaults to useSeperateListener
if a replyTo address is given, even though the user has done just a
serviceClient.sendReceive(payload);...  I doubt whether this is
correct...

There can be scenerio's where users might already be having a listener
up and running for the given replyTo address.. In that case trying to
setup a new listener can give us lot of troubles...

Thanks,
Thilina


>
>          if (useAsync || options.isUseSeparateListener()) {
>              sendAsync(useAsync, mc);
> @@ -248,17 +252,18 @@
>              useCustomListener = Boolean.TRUE;
>          }
>          if (useCustomListener == null || !useCustomListener.booleanValue()) {
> -
> -            EndpointReference replyToFromTransport =
> -                    mc.getConfigurationContext().getListenerManager().
> -                            getEPRforService(sc.getAxisService().getName(),
> -                                    axisOp.getName().getLocalPart(), mc
> -                                    .getTransportIn().getName());
> -
> -            if (mc.getReplyTo() == null) {
> -                mc.setReplyTo(replyToFromTransport);
> -            } else {
> -                mc.getReplyTo().setAddress(replyToFromTransport.getAddress());
> +            if(mc.getReplyTo()==null){
> +                EndpointReference replyToFromTransport =
> +                        mc.getConfigurationContext().getListenerManager().
> +                                getEPRforService(sc.getAxisService().getName(),
> +                                        axisOp.getName().getLocalPart(), mc
> +                                        .getTransportIn().getName());
> +
> +                if (mc.getReplyTo() == null) {
> +                    mc.setReplyTo(replyToFromTransport);
> +                } else {
> +                    mc.getReplyTo().setAddress(replyToFromTransport.getAddress());
> +                }
>              }
>          }
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>


-- 
Thilina Gunarathne  -  http://www.wso2.com - http://thilinag.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org