You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/02/18 20:06:18 UTC
Change in asterixdb-clients[master]: [NO ISSUE] Fix generation of boolean literals
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383 )
Change subject: [NO ISSUE] Fix generation of boolean literals
......................................................................
[NO ISSUE] Fix generation of boolean literals
Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
---
M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-clients refs/changes/83/15383/1
diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
index 076abd2..bef055e 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
+++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
@@ -1475,7 +1475,6 @@
<part name='second' value='SECOND' />
</date-part-group>
</date-parts>
- <format-bool-as-value value='TrueFirst' />
<format-column-definition>
<local-type name='int'>
<remote-type name='I1' value='TINYINT' />
@@ -1508,7 +1507,7 @@
<format-drop-table>
<formula>DROP DATASET %1</formula>
</format-drop-table>
- <format-false value='FALSE' />
+ <format-false literal='FALSE' predicate='FALSE' />
<format-if-then-else value='Case' />
<format-index value='ColumnNameOnly' />
<format-insert value='Individual' />
@@ -1526,7 +1525,7 @@
<format-simple-case value='Case' />
<!--format-stored-proc-call--> <!-- Not supported -->
<format-string-literal value='Extended' />
- <format-true value='TRUE' />
+ <format-true literal='TRUE' predicate='TRUE' />
<icu-date-token-map>
<!-- used by DATEPARSE -->
<!-- http://userguide.icu-project.org/formatparse/datetime -->
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
Gerrit-Change-Number: 15383
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-MessageType: newchange
Change in asterixdb-clients[master]: [NO ISSUE] Fix generation of boolean literals
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383 )
Change subject: [NO ISSUE] Fix generation of boolean literals
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
Gerrit-Change-Number: 15383
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Comment-Date: Fri, 18 Feb 2022 20:08:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb-clients[master]: [NO ISSUE] Fix generation of boolean literals
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383 )
Change subject: [NO ISSUE] Fix generation of boolean literals
......................................................................
[NO ISSUE] Fix generation of boolean literals
Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
---
M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-clients refs/changes/83/15383/1
diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
index 076abd2..bef055e 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
+++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
@@ -1475,7 +1475,6 @@
<part name='second' value='SECOND' />
</date-part-group>
</date-parts>
- <format-bool-as-value value='TrueFirst' />
<format-column-definition>
<local-type name='int'>
<remote-type name='I1' value='TINYINT' />
@@ -1508,7 +1507,7 @@
<format-drop-table>
<formula>DROP DATASET %1</formula>
</format-drop-table>
- <format-false value='FALSE' />
+ <format-false literal='FALSE' predicate='FALSE' />
<format-if-then-else value='Case' />
<format-index value='ColumnNameOnly' />
<format-insert value='Individual' />
@@ -1526,7 +1525,7 @@
<format-simple-case value='Case' />
<!--format-stored-proc-call--> <!-- Not supported -->
<format-string-literal value='Extended' />
- <format-true value='TRUE' />
+ <format-true literal='TRUE' predicate='TRUE' />
<icu-date-token-map>
<!-- used by DATEPARSE -->
<!-- http://userguide.icu-project.org/formatparse/datetime -->
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
Gerrit-Change-Number: 15383
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-MessageType: newchange
Change in asterixdb-clients[master]: [NO ISSUE] Fix generation of boolean literals
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Dmitry Lychagin <dm...@couchbase.com>:
Dmitry Lychagin has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383 )
Change subject: [NO ISSUE] Fix generation of boolean literals
......................................................................
[NO ISSUE] Fix generation of boolean literals
Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Dmitry Lychagin <dm...@couchbase.com>
Reviewed-by: Ian Maxon <im...@uci.edu>
---
M asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Ian Maxon: Looks good to me, approved
Dmitry Lychagin: Looks good to me, but someone else must approve
Jenkins: Verified
diff --git a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
index 076abd2..bef055e 100644
--- a/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
+++ b/asterixdb-jdbc/asterix-jdbc-taco/src/main/taco/plugins/asterixdb_jdbc/dialect.tdd
@@ -1475,7 +1475,6 @@
<part name='second' value='SECOND' />
</date-part-group>
</date-parts>
- <format-bool-as-value value='TrueFirst' />
<format-column-definition>
<local-type name='int'>
<remote-type name='I1' value='TINYINT' />
@@ -1508,7 +1507,7 @@
<format-drop-table>
<formula>DROP DATASET %1</formula>
</format-drop-table>
- <format-false value='FALSE' />
+ <format-false literal='FALSE' predicate='FALSE' />
<format-if-then-else value='Case' />
<format-index value='ColumnNameOnly' />
<format-insert value='Individual' />
@@ -1526,7 +1525,7 @@
<format-simple-case value='Case' />
<!--format-stored-proc-call--> <!-- Not supported -->
<format-string-literal value='Extended' />
- <format-true value='TRUE' />
+ <format-true literal='TRUE' predicate='TRUE' />
<icu-date-token-map>
<!-- used by DATEPARSE -->
<!-- http://userguide.icu-project.org/formatparse/datetime -->
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb-clients/+/15383
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb-clients
Gerrit-Branch: master
Gerrit-Change-Id: If96bbfbeb1f0be3bdf70d04dc0bed4da85299d9f
Gerrit-Change-Number: 15383
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-MessageType: merged