You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2025/05/09 16:27:53 UTC
[PR] [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity` [spark-connect-swift]
dongjoon-hyun opened a new pull request, #118:
URL: https://github.com/apache/spark-connect-swift/pull/118
### What changes were proposed in this pull request?
This PR aims to fix `DataFrame` to use `SparkSession`'s `transportSecurity`.
### Why are the changes needed?
To support TLS correctly. This issue was reported during `v0.1.0 RC1` vote.
### Does this PR introduce _any_ user-facing change?
Yes, but it's a bug fix which the previous behavior is not proper.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #118: [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity`
URL: https://github.com/apache/spark-connect-swift/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #118:
URL: https://github.com/apache/spark-connect-swift/pull/118#issuecomment-2867169137
BTW, thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity` [spark-connect-swift]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #118:
URL: https://github.com/apache/spark-connect-swift/pull/118#discussion_r2082036315
##########
Sources/SparkConnect/DataFrame.swift:
##########
@@ -279,7 +279,7 @@ public actor DataFrame: Sendable {
try await withGRPCClient(
transport: .http2NIOPosix(
target: .dns(host: spark.client.host, port: spark.client.port),
- transportSecurity: .plaintext
+ transportSecurity: spark.client.transportSecurity
Review Comment:
The fix looks good. How does it test? Manually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #118:
URL: https://github.com/apache/spark-connect-swift/pull/118#issuecomment-2867168520
Actually, the setup is not easy. I believe the only way is to test against the commercial vendor's TLS-enabled Spark Connect Server. I tried to launch and use Databricks Community Edition, but I couldn't find a way to get Spark Connect server there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52059] Fix `DataFrame` to use SparkSession's `transportSecurity` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #118:
URL: https://github.com/apache/spark-connect-swift/pull/118#issuecomment-2867273809
Merge to main~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org