You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (Closed) (JIRA)" <ji...@apache.org> on 2011/11/06 05:24:52 UTC
[jira] [Closed] (WICKET-579) Need for DataTable not to require size
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson closed WICKET-579.
-----------------------------------
Resolution: Won't Fix
Assignee: Jeremy Thomerson
I'm going through cleaning up some older tickets and am going to close this as won't fix. This one has been open 4 1/2, going on five years. As mentioned throughout, if something like this were implemented it would not really be an "improvement" to the existing data table, but rather an orthogonal use case. InMethod grid provides one such example of a component that can be used for such a use-case. I believe that if folks still want this, they should re-open this (or create a new) ticket only when they either:
1 - have a patch that both provides for the quite-different usecase of a data table (and/or other pageable views) with an unknown size, extending the current component(s) to work with this usecase while preserving all current functionality and API for users.
OR
2 - have an alternate component ([hierarchy]) that provides for such a use case, hopefully keeping the API as similar to the existing API (perhaps even by reusing classes from the existing API) as possible
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Assignee: Jeremy Thomerson
> Attachments: WICKET-578.patch, wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira