[GitHub] [dubbo] CrazyHZM commented on a change in pull request #9741: add some comment to StringUtil

[GitBox <gi...@apache.org>]

CrazyHZM commented on a change in pull request #9741:
URL: https://github.com/apache/dubbo/pull/9741#discussion_r820404643



##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
##########
@@ -530,19 +532,31 @@ public static boolean isEquals(String s1, String s2) {
     }
 
     /**
-     * is integer string.
+     * is positive integer or zero string.

Review comment:
       It may be more appropriate to change to the following expression: “determine whether it is a positive integer or zero string”

##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
##########
@@ -515,8 +515,10 @@ public static boolean isNotEmpty(String str) {
     }
 
     /**
-     * @param s1
-     * @param s2
+     * if s1 is null and s2 is null, then return true

Review comment:
       The content description of the method is not completed.
   

##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
##########
@@ -530,19 +532,31 @@ public static boolean isEquals(String s1, String s2) {
     }
 
     /**
-     * is integer string.
+     * is positive integer or zero string.
      *
-     * @param str
-     * @return is integer
+     * @param str a string
+     * @return is positive integer or zero

Review comment:
       The return should be the judgment result.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org